Repository navigation
[TS] Preserve compound and logical assignment references - #425
Merged
Merged
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/ts-postfix-tonumeric
branch
from
October 7, 2026 21:41
8de6b35 to
ba84126
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-assignment-reference-capture
branch
from
October 7, 2026 21:41
e837504 to
2a1435f
Compare
This was referenced Oct 7, 2026
CaelmBleidd
force-pushed
the
caelmbleidd/ts-postfix-tonumeric
branch
from
October 10, 2026 17:41
ba84126 to
fe4515d
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-assignment-reference-capture
branch
from
October 10, 2026 17:41
2a1435f to
70b76e6
Compare
CaelmBleidd
changed the base branch from
caelmbleidd/ts-postfix-tonumeric
to
neo
October 10, 2026 17:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
receiver.m += 1reads an object whosevalueOfreplaces the capturedreceiverbinding, the frontend previously stored the result in the replacement object. Compound and logical assignments now save their selected receiver and raw index before Get or coercion can change those bindings. Logical assignments also preserve that selection when an accessor getter changes the source binding before the assign/keep decision.Validation: fresh typecheck and focused frontend tests (57 passed) on the exact rewritten head. The complete semantic stack at original #425 also passed the frontend build and 622 tests. Rebase preserved the original production tree exactly. For #421 and later, the expected tree also carries the reviewed Kotlin for-await assertion corrections. Frontend/JSON/model correctness does not establish downstream USVM execution support.