Repository navigation
[TS] Evaluate computed object-binding keys once (#384) - #412
Merged
Merged
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/ts-384-computed-bindings
branch
from
October 10, 2026 17:35
b610506 to
6a6b247
Compare
CaelmBleidd
changed the base branch from
caelmbleidd/ts-382-object-rest
to
neo
October 10, 2026 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computed object-binding keys now undergo ToPropertyKey once, and the same converted key is reused for both property access and rest exclusion. The source remains stable across key side effects, nullish-source rejection precedes key evaluation, and computed bindings also lower inside for-of loops.
Validation: fresh typecheck and focused frontend tests (5 passed) on the exact rewritten head. The complete semantic stack at original #425 also passed the frontend build and 622 tests. Rebase preserved the original source tree exactly. Frontend/JSON/model correctness does not establish downstream USVM execution support.
Fixes #384