Repository navigation
[TS] Preserve computed property Get and Put evaluation order - #423
Merged
Merged
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/ts-support-frontend-regressions
branch
from
October 7, 2026 21:41
46e3ef9 to
e0c782a
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-computed-access-order
branch
from
October 7, 2026 21:41
cfbf2ea to
cae216a
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-support-frontend-regressions
branch
from
October 10, 2026 17:41
e0c782a to
103b982
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-computed-access-order
branch
from
October 10, 2026 17:41
cae216a to
06bc399
Compare
CaelmBleidd
changed the base branch from
caelmbleidd/ts-support-frontend-regressions
to
neo
October 10, 2026 17:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic computed property reads, calls and tags now evaluate the key expression, reject a nullish receiver, and then perform key coercion in the correct order. Computed write references retain the raw key so Get and Put each convert it at their own evaluation point; ordinary assignment evaluates and saves its RHS before Put-time coercion. An obsolete PropertyRef fallback is removed from the replaced computed-write path. The scope is key/Get/Put ordering; numeric conversion of postfix results is outside this change.
Validation: fresh typecheck and focused frontend tests (22 passed) on the exact rewritten head. The complete semantic stack at original #425 also passed the frontend build and 622 tests. Rebase preserved the original production tree exactly. For #421 and later, the expected tree also carries the reviewed Kotlin for-await assertion corrections. Frontend/JSON/model correctness does not establish downstream USVM execution support.