Repository navigation
[TS] Lock the rest-parameter caller packing contract (#373) - #420
Merged
Merged
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/ts-373-rest-parameter-contract
branch
from
October 7, 2026 21:41
fe89681 to
790f734
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-372-parameter-defaults
branch
from
October 10, 2026 17:38
a915f6e to
e0cbb16
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-373-rest-parameter-contract
branch
from
October 10, 2026 17:38
790f734 to
9d6f52d
Compare
CaelmBleidd
changed the base branch from
caelmbleidd/ts-372-parameter-defaults
to
neo
October 10, 2026 17:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR documents and tests the existing rest-parameter contract: the frontend emits isRest and raw call arguments, and the call consumer packs trailing arguments into the array read through ParameterRef. It adds JSON/model metadata preservation and regression cases for empty/multiple rest arguments, ordering, and missing ordinary parameters. The production change is a documentation line; no new frontend packing implementation is introduced.
Validation: fresh typecheck and focused frontend tests (3 passed) on the exact rewritten head. The complete semantic stack at original #425 also passed the frontend build and 622 tests. Rebase preserved the original source tree exactly. Frontend/JSON/model correctness does not establish downstream USVM execution support.
Fixes #373