Repository navigation
fix: keep sheet buttons above the navigation bar - #1572
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Low impact] The PR appears safe to merge; no new actionable issues were found. SummaryAdds bottom navigation-bar padding to the Forgot PIN sheet and the unavailable subscription sheet.
Reviews (2) · Last reviewed commit: "test: return home before locking in forg..." · Reviewed by Greptile |
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Adds navigationBarsPadding() to the Forgot PIN sheet and to the Subscription sheet's unavailable state, so their bottom buttons clear the gesture handle. Reviewed 109b671, light tier, reasoned from the code and CI: I do not build Bitkit Android branches.
What I checked, and 3 candidates I ruled out
Read in full: ForgotPinSheet.kt, SubscriptionSheet in SubscriptionsScreen.kt, forgot-pin-nav-bar-inset.xml, the changelog fragment
Call sites traced: ForgotPinSheet (one caller, MainActivity), BottomSheet -> BottomSheetOverlayHost -> SheetHost, Modifier.sheetHeight
CI: build, build-local, lint and detekt green; the e2e jobs were still running
Ruled out
- Double inset:
SheetHostandBottomSheetOverlayHostapply no window insets, and the sibling sheets (DisablePinSheet,ChangePinSheet, the other subscription routes) each pad themselves, so this is the house pattern, not a second inset. - Gradient stops short of the screen edge: in
ForgotPinSheetthe padding comes aftergradientBackground(), and inSubscriptionSheetit is on the innerColumnwhile theBoxcarries the gradient, so the background still fills the inset. - Fixed height clips the content:
sheetHeight(isModal = true)fixes the outer height and the padding comes out of theFillHeight()slots, which leaves room on any phone height.
Merge confidence: 5/5, CI build and lint green, and the change is one house-pattern modifier per screen that a unit test would not apply to; the new journey checks it on a device.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This PR adds the navigation-bar inset to two sheet screens whose bottom button sat under the gesture handle. They were found by checking every sheet screen for the same bug as #1523, which #1564 fixes for the USDT payment review.
Description
Out of Scope
ui/screens/wallets/usdt: the USDT payment review and USDT activity detail insets ([Bug]: Contact USDT confirmation swipe overlaps Android system navigation #1523) ship in fix: improve usdt payment feedback and layout #1564.Design
N/A — no design change; the screens keep their existing layout and only gain the bottom safe-area padding. No Figma frame is linked because I did not confirm the matching handoff frames.
Preview
Forgot PIN sheet on a Pixel 9 emulator with gesture navigation: Reset ends at y=2319, above the navigation bar at y=2361.
QA Notes
Journeys
forgot-pin-nav-bar-inset.xml— the Forgot PIN sheet's Reset button sits above the navigation barManual Tests
Automated Checks
N/A