Repository navigation
fix: keep sheet buttons above the navigation bar #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
109b671
fix: keep sheet buttons above the navigation bar
jvsena42 5eb5435
test: match forgot pin journey to on-device tags
jvsena42 965d98f
docs: mark forgot pin inset journey android-only
jvsena42 c61445b
test: return home before locking in forgot pin journey
jvsena42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| The Forgot PIN and unavailable subscription sheets now keep their buttons above the navigation bar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <journey name="forgot pin sheet clears navigation bar"> | ||
| <description> | ||
| The "Forgot PIN?" sheet keeps its "Reset (Requires Recovery Phrase)" button above the | ||
| navigation bar. The sheet host applies no bottom inset, so the sheet content has to; without it | ||
| the button sits under the gesture handle on devices with gesture navigation. | ||
|
|
||
| Precondition: onboarded dev wallet with gesture navigation enabled on the device and the PIN | ||
| disabled (Settings ▸ Security ▸ PIN Code shows "Disabled"), no biometrics enrolled on the | ||
| device. Start on the wallet home screen. The journey enables a PIN you choose and disables it | ||
| again at the end, so remember it. Enter a wrong PIN exactly once: exhausting attempts leads to | ||
| the forgot-PIN wallet reset, and never tap the Reset button. | ||
|
|
||
| The navigation-bar top edge is the screen height (`adb shell wm size`) minus the bottom | ||
| `navigationBars` inset that `adb shell dumpsys window windows` reports. `android layout` gives | ||
| the Reset button no bounds and no tag, so read its bounds from `adb shell uiautomator dump`. With | ||
| no biometrics enrolled, the biometrics Skip button exposes only its text. Android only; see the | ||
| cross-platform table in `journeys/README.md`. | ||
| </description> | ||
| <actions> | ||
| <action>Tap the menu button (tag "HeaderMenu") and tap Settings (tag "DrawerSettings")</action> | ||
| <action>Tap the Security tab (tag "Tab-security")</action> | ||
| <action>Tap PIN Code (tag "PINCode")</action> | ||
| <action>Tap Enable PIN (tag "EnablePin")</action> | ||
| <action>Enter a 4-digit PIN with the number pad (tags "N0"–"N9")</action> | ||
| <action>Re-enter the same 4-digit PIN to confirm it</action> | ||
| <action>On the biometrics screen, tap Skip</action> | ||
| <action>Tap OK (tag "OK")</action> | ||
| <action>Press back until the wallet home screen is visible (testTag "Send")</action> | ||
| <action>Run adb shell input keyevent KEYCODE_HOME and wait 3 seconds</action> | ||
| <action>Run adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity</action> | ||
| <action>Verify the PIN pad is visible with the text "Please enter your PIN code" and keys (tag "N1")</action> | ||
| <action>Enter one wrong 4-digit PIN</action> | ||
| <action>Verify the attempts text (tag "AttemptsRemaining") reads "... attempts remaining. Forgot your PIN?"</action> | ||
| <action>Tap the attempts text (tag "AttemptsRemaining")</action> | ||
| <action>Verify the "Forgot PIN?" sheet is visible (tag "ForgotPIN")</action> | ||
| <action>Verify from `adb shell uiautomator dump` that the bottom bound of the "Reset (Requires Recovery Phrase)" button is above the navigation-bar top edge</action> | ||
| <action>Take a screenshot and verify the gesture handle does not overlap the Reset button</action> | ||
| <action>Press back and verify the PIN pad is visible again with keys (tag "N1")</action> | ||
| <action>Enter the PIN chosen above and verify the wallet home screen is visible (testTag "Send")</action> | ||
| <action>Tap the menu button (tag "HeaderMenu") and tap Settings (tag "DrawerSettings")</action> | ||
| <action>Tap the Security tab (tag "Tab-security")</action> | ||
| <action>Tap PIN Code (tag "PINCode")</action> | ||
| <action>Tap Disable PIN (tag "DisablePin") and enter the PIN chosen above on the "Disable PIN" screen</action> | ||
| <action>Verify the PIN Code row (tag "PINCode") shows "Disabled"</action> | ||
| </actions> | ||
| </journey> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.