[ovitrif]

Closes #1628
Twin: synonymdev/bitkit-ios#1062

This PR makes the expanded USDT confirm fit the longest set of details (contact, address and invoice note on a Paykit request): the fee hint now scrolls with the details under Hide Details, and Swipe To Pay stays pinned.

Description

• Moves the fee hint ("All fees are paid in USDT. Final fee may be lower.") from the pinned area above Swipe To Pay into the scrolling details, right under Hide Details, so the two never collide.
• Keeps the hint at the bottom of the details area when everything fits, as before, and lets it follow Hide Details when the details overflow and scroll; Swipe To Pay stays pinned either way.
• Adds that check to usdt-send-review-and-details.xml.

Out of Scope

• UsdtSendContent.kt collapsed confirm, Amount and submitted states: unchanged.
• Swipe To Pay under the navigation bar: fix: keep sheet buttons above the navigation bar #1572, already fixed on master.

Design

Bitkit - Refactor v63 › Send (USDT) › Confirm Details USDT. The frame shows a direct send without the Contact and Invoice Note rows; this PR keeps its order (details, Hide Details, fee hint, Swipe To Pay) and makes it scroll when a Paykit request adds those rows.

Preview

Before, 3.0.1 (contact and address masked):

After, regtest with a local test hook supplying the quote, contact and invoice note: details open, then scrolled to the fee hint:

Details open	Scrolled to fee hint

a1637-details-2x.mp4

After, a plain send whose details fit, next to the Figma frame: the hint stays at the bottom and a gentle drag moves nothing:

Figma	App

QA Notes

Journeys

• updated usdt-send-review-and-details.xml — the fee hint sits below Hide Details and scrolls with the details, with Swipe To Pay pinned
• updated paykit-quoted-usdt.xml — a USDT request with contact and a long invoice note: details scroll past Hide Details to the fee note, with Swipe To Pay pinned

Manual Tests

• Open a Paykit request paid in USDT with an invoice note, continue to review and tap Show Details → Contact, Address and Invoice Note scroll with Hide Details and the fee hint above a pinned Swipe To Pay, nothing overlaps — an incoming Payment Request needs the fixture issuer from journeys/README.md plus a USDT quote, which needs the local USDT fixture

Automated Checks

N/A

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-20T23:54:41.284780Z	638ab48	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[ovitrif]

QA on an Android 16 emulator (1080×2400, 420 dpi), regtest debug build of this branch with a local-only hook that supplies the quote, contact and invoice note:

• Payment Request confirm with Contact, Address and Invoice Note: Show Details lays out every row; the content scrolls, the Hide Details pill and the fee hint follow it 52 px apart, and Swipe To Pay stays pinned 43 px above the navigation bar.
• Plain send whose details fit: the fee hint sits at the bottom above Swipe To Pay as before, and gentle drags up and down move nothing (frames taken mid-drag are identical).
• testDevDebugUnitTest, lintDevDebug and detekt pass.

[greptile-apps]

Confidence Score: 4/5

[Low impact] The change is limited to the expanded USDT send confirmation layout.

The PR appears safe to merge, with a non-blocking gap in the journey’s overflow check.

Findings

1.  Crowded review goes untested ▶

Summary

Moves the expanded USDT fee hint into the scrolling details while keeping Swipe To Pay outside that area.

• The USDT fee hint scrolls with expanded details above Swipe To Pay.

_{Reviews (1) · Last reviewed commit: "fix: fit usdt confirm details above a pi..." · Reviewed by Greptile}

[github-actions]

Regtest APK

Built from c6068a1 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

[ovitrif]

Pushed c6068a1: journeys/paykit-quoted-usdt.xml gains a step for a USDT request whose details overflow, with a contact and a long invoice note. It checks that the fee note scrolls with Hide Details and Swipe To Pay stays pinned. The step in usdt-send-review-and-details.xml runs on a plain send whose details may fit, so this one covers the overlap this PR fixes. It answers the Greptile finding. The Journeys list in the description now names both files. No app code changed. The same step is on the iOS twin, synonymdev/bitkit-ios#1062.

[jvsena42]

Code scan at c6068a1: no issues found.

• Layout: the fee note sits after a flexible spacer inside the min-height scroll column. When the details fit, it sits at the bottom; when they overflow, it follows Hide Details. Swipe to pay stays pinned outside the scroll.
• Show/Hide: each toggle scrolls back to the top, so the amount header is visible.
• Reachability: amount, Pay from, Network, Payment, Fee, Address, Contact and Note all stay reachable by scrolling. Nothing is clipped.
• Parity: same structure, journey text and changelog sentence as synonymdev/bitkit-ios#1062.
• Journeys: usdt-send-review-and-details.xml and paykit-quoted-usdt.xml updated. The new Paykit step covers Greptile's resolved thread.

Device gate (partial): c6068a1 — not run yet. Pending: a Paykit USDT request with a contact and a wrapped note → Show Details → scroll and Hide Details, with no overlap and Swipe pinned. Then a plain send on a short screen with large text (iPhone SE with the largest Dynamic Type on iOS).

Device results will follow in a separate review.

[jvsena42]

Device gate (partial): c6068a1 — not run. The USDT fixture went down (Docker stopped on a full disk) before this PR's turn on the Android lane, and the pass is paused. Pending:

• Show Details overflow, with Swipe pinned and the header visible after each toggle;
• font scale 1.3 on a short display;
• usdt-send-review-and-details.xml and paykit-quoted-usdt.xml.

The iOS twin's layout checks passed on synonymdev/bitkit-ios#1062.