docs: sync documentation with recent changes - #135
Merged
Merged
Conversation
Fix two small gaps left by PRs merged since #103, both verified against the code on main: - README.md: the Python SDK section's list of NL2SQL public attributes omitted engine.auth (AuthAPI), which the same paragraph's convenience methods (check_permissions, get_allowed_resources) delegate to. - web/playground/README.md: the Settings panel's per-node model selector ids were missing #model-datasourceresolver, added by #121's answerability check node. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HyeURBJcF67mhU6v1apcoD
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review window
Prior "docs: sync documentation with recent changes" PR: #103, created 2026-09-21T12:12:49Z. This reviews everything merged into
mainsince then: #102 and #104–#132 (23 PRs; #85 is release-please's ownchore: release mainand carries no doc-relevant content beyondCHANGELOG.md, which release-please owns).Nearly all of that window (#104–#132, #102) already keeps README.md and
docs/in sync as part of each PR's own commits — verified with four independent audits covering the CLI reference and configuration tables, the REST API and Python SDK sections, the playground/demo docs, and the architecture/pipeline docs, each cross-checked against the current code onmain, not just the PR diffs. #131 in particular rewrote README.md against the code as of its base and added drift tests (every CLI command and every FastAPI route must appear in the README), so the bulk of the surface is now self-verifying.This PR covers the two gaps that survived that rewrite.
Corrections
README.md — Python SDK section: the list of
NL2SQL's public attributes (engine.query,engine.datasource,engine.llm, ...) omittedengine.auth.packages/nl2sql/src/nl2sql/public_api.pysetsself.auth = AuthAPI(self._ctx)as a real public attribute, documented indocs/api/core/auth.md, and the same README paragraph already mentions thecheck_permissions/get_allowed_resourcesconvenience methods that delegate to it. Addedengine.authto the list.web/playground/README.md — Settings panel: the "Model for each step" bullet listed 4 per-node selector ids (
#model-decomposer,#model-astplanner,#model-refiner,#model-answersynthesizer) but the panel now renders 5, one per entry inLLM_NODES(packages/nl2sql/src/nl2sql/cli/demo/playground/settings.py). Added the missing#model-datasourceresolver, matching the wording already correct indocs/getting_started/demo.mdandREADME.md.datasourceresolvernode toLLM_NODESand updateddocs/getting_started/demo.md, but missed this file)Verification
main, not just the PR diffs.Settings; (2) REST API + Python SDK docs vs. FastAPI routes and the public facade; (3) playground/demo docs vs. the demo backend routes and React components; (4) architecture/pipeline docs vs. RBAC, plan cache, resolver, sub-query status, generator, retrieval-trace and provider-adapter code. No other drift traceable to a PR in this window was found, and no new user-facing behavior from this window is undocumented.pip install -r requirements-docs.txt && python -m mkdocs build --strict: fails with exactly one warning —mkdocs-mermaid2-plugincannot reachunpkg.comto verify the mermaid.js CDN URL, rejected by this sandbox's outbound network policy (connect_rejected, gateway 403 per$HTTPS_PROXY/__agentproxy/status). This is the same sandbox-only failure documented by the three prior sync PRs (docs: sync documentation with recent changes #60, docs: sync documentation with recent changes #77, docs: sync documentation with recent changes #103). With no other warnings, every content and nav validation passes.Not touched
CHANGELOG.mdand version numbers (release-please owns those).Four older, pre-existing doc inaccuracies noticed along the way but not fixed here because they predate this review window (all introduced by test: add OpenAI-compatible fake LLM and first end-to-end CLI test #82, merged 2026-08-28, well before docs: sync documentation with recent changes #103):
docs/architecture/nodes/ast_planner_node.mdanddocs/architecture/nodes/answer_synthesizer_node.mdname the LLM config agent keys asast_planner/answer_synthesizer(with underscores) instead of the actualastplanner/answersynthesizerthe registry looks up.docs/architecture/subgraphs/sql_agent.md's routing step 5 description of the WARNING-only retry path is stale relative todocs/architecture/failure_recovery.md's correct description of the same code.docs/configuration/datasources.mdshowsstatement_timeout_ms/row_limit/max_bytes/tagsas siblings ofconnection, butDatasourceConfigonly keepsid/description/connection/optionsand silently drops unknown top-level keys — they need to be nested underoptions:.docs/configuration/llm.md's first example usesmodel: gpt-5.2, which is not the default anywhere in the code (the rest of the same file, and README, correctly usegpt-5.4).Flagging all four for a maintainer follow-up since they're out of this PR's window.
Everything else in feat(trace): record every node of a run to one file, show it, and replay it without the model #104–fix(generator): render string concatenation as the dialect's own, never numeric + #132 already kept in sync via each PR's own commits.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HyeURBJcF67mhU6v1apcoD