docs: sync documentation with recent changes - #167
Merged
Merged
Conversation
- README.md: the tier-2 benchmark CLI table and the eval-tiers paragraph still described --baseline as a flat accuracy-drop gate; add --max-regressions and --max-cost-increase to the flag list and describe the paired McNemar regression gate, noting --max-accuracy-drop is now deprecated. (#156) - docs/adapters/architecture.md, docs/extensions/add-adapter.md, docs/adapters/sdk.md: drop references to supports_schema_introspection, supports_dry_run and supports_cost_estimate, which no longer exist on DatasourceCapability (only supports_sql and supports_rest remain); fix the now-incorrect claim that fetch_schema_snapshot() is gated by a capability flag. (#163) - packages/nl2sql/README.md: the demo now seeds three SQLite databases (Chinook, support, webanalytics), not just Chinook (#157); Settings moved from a panel to its own routed page (#154); and nl2sql demo --hosted, a public-facing mode with no server-side key, was entirely undocumented here (#165). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bft4Niqsd2GWnPopt1VAhd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review window
Prior "docs: sync documentation with recent changes" PR: #135, created 2026-09-22T12:17:37Z. This reviews everything merged into
mainsince then: #133, #137–#165 (28 PRs merged after that timestamp; excludes #135 itself and #153, which was closed without merging).Four parallel audits covered this window, each cross-checked against the current code on
main, not just the PR diffs: (1) API/SDK — auth, registry, facade, dead-code removal; (2) pipeline/architecture — generator, validator, decomposer, aggregator fixes; (3) playground/demo — page nav, sample databases, hosted mode; (4) eval/benchmark — tier 2 scoring, regression gate.Most of the window already keeps docs in sync as part of each PR's own commits — in particular #154, #156, #157, #160, #163, #164, #165 all touched README.md/docs/ themselves. This PR covers what survived that self-documentation.
Corrections
README.md — tier 2 benchmark CLI table and gate description: the
nl2sql benchmark --tier 2row's flag list and the "--baselinefails on a regression" sentence still described the old flat accuracy-drop gate. feat(eval): alternative gold answers, confidence intervals and a paired regression gate #156 added--max-regressions(default 2: how many questions may flip pass→fail before the run fails) as the primary gate, made--max-accuracy-dropoptional and deprecated, and switched the comparison to a paired McNemar significance test on flipped questions (packages/nl2sql/src/nl2sql/cli/main.py:361-375). Added--max-regressions,--max-accuracy-drop(deprecated) and the pre-existing but likewise-missing--max-cost-increaseto the table, and rewrote the gate description.docs/adapters/architecture.md, docs/extensions/add-adapter.md, docs/adapters/sdk.md: all three still told adapter authors to declare
supports_schema_introspection,supports_dry_runorsupports_cost_estimatecapability flags. chore: remove dead code and fix the timeout message and CANCELLED code #163 prunedDatasourceCapabilitydown to onlySUPPORTS_SQLandSUPPORTS_REST(packages/adapter-sdk/src/nl2sql_adapter_sdk/capabilities.py) and fixed most references itself, but missed these three spots — followingadd-adapter.md's old instructions today would raiseAttributeErroron the deleted enum members. Also fixedsdk.md's claim thatfetch_schema_snapshot()is "required only ifsupports_schema_introspectionis advertised" — it's a required protocol method now (packages/adapter-sdk/src/nl2sql_adapter_sdk/protocols.py:26), not gated by any capability flag.packages/nl2sql/README.md — three gaps, all in a file docs(playground): describe the pages and several databases in the README and rail #160 and feat(demo): hosted mode so a public demo can take each visitor's own key #165 edited elsewhere but not here:
nl2sql demowrites a project "with the Chinook sample database" (singular). feat(demo): add support and web-analytics sample databases linked to Chinook customers #157 added two more sample databases; the demo now copies in three (packages/nl2sql/src/nl2sql/cli/demo/manager.py:67-68:chinook,support,webanalytics), as rootREADME.md:100-101already correctly says.#/settings); feat(playground): give Settings and Retrieval their own pages with a header nav #154's own diff fixed this phrase everywhere else (docs/configuration/llm.md,docs/configuration/secrets.md,docs/getting_started/demo.md) but missed this file.nl2sql demo --hostedat all. feat(demo): hosted mode so a public demo can take each visitor's own key #165 added a public-facing hosted mode (no server-side key; each visitor supplies their own,packages/nl2sql/src/nl2sql/cli/demo/playground/hosted.py) and documented it in rootREADME.md:149-155,web/playground/README.mdanddocs/getting_started/demo.md, but this package-level README — which is the one PyPI actually shows — had no mention of it.Verification
main, not just the PR diffs.pip install -r requirements-docs.txt && python -m mkdocs build --strict: fails with exactly one warning —mkdocs-mermaid2-plugincannot reachunpkg.comto verify the mermaid.js CDN URL, rejected by this sandbox's outbound network policy (connect_rejected, gateway 403 per$HTTPS_PROXY/__agentproxy/status). This is the identical sandbox-only failure documented by all four prior sync PRs (docs: sync documentation with recent changes #60, docs: sync documentation with recent changes #77, docs: sync documentation with recent changes #103, docs: sync documentation with recent changes #135). With no other warnings, every content and nav validation passes.Not touched
CHANGELOG.mdand version numbers (release-please owns those).🤖 Generated with Claude Code
https://claude.ai/code/session_01Bft4Niqsd2GWnPopt1VAhd
Generated by Claude Code