Conversation
Review window: everything merged into main after PR #167 (the prior sync), i.e. #168-#179 (the hosted Hugging Face Space, its per-step model selection, the Pipeline page, the database switcher, the ordinal-field removal, and the global-planner-into-decomposer refactor). Each of those PRs already updated most of its own docs; this covers what survived that self-documentation, verified against the current code on main rather than the diffs. - docs/architecture/invariants.md: dropped the "Relation Schemas Have Unique Column Names" section and its "State" category listing. RelationSchema and ColumnSpec were deleted by #177; nothing in packages/ references them any more. - docs/architecture/failure_recovery.md (two spots) and docs/architecture/graph_state.md: dropped "global planner" from the retry and no-local-recovery node lists, and "DAG hashes" from what GraphState carries. #177 deleted the standalone global_planner node (folded into decomposer/dag.py) and ExecutionDAG's dag_id/content_hash fields. - docs/deployment/hosted-demo.md and deploy/huggingface/README.md: the query timeout was documented as 60s, but the demo project's .env.demo template (cli/generators/env/templates.py) overrides GLOBAL_TIMEOUT_SEC to 300, and the Dockerfile never overrides it back down, so 300s is the actual hosted default. Also noted that a push to the workflow file itself (.github/workflows/publish_space.yml) redeploys, per its own path trigger. - web/playground/README.md: added the missing /api/pipeline route to the dev route list, added src/pipeline.js, src/hostedKey.js and src/hostedModels.js (each with its own test file) to the npm test description, and fixed router.js's stale line count (110 -> 119). - docs/getting_started/demo.md: the Pipeline page section said nine non-model steps; pipeline/steps.py lists 13 steps total and llm/providers.py's LLM_AGENTS names 5 as model-decided, leaving eight. - docs/configuration/llm.md: "Settings panel" -> "Settings page", matching the rest of the same file (Settings has been a routed page since #154). Not touched: CHANGELOG.md and version numbers (release-please owns those). Everything else in the window's own doc edits was checked and found consistent with the current code. Verification: pip install -r requirements-docs.txt && python -m mkdocs build --strict fails with exactly one warning -- mkdocs-mermaid2-plugin cannot reach unpkg.com to verify the mermaid.js CDN URL, rejected by this sandbox's outbound network policy. This is the identical sandbox-only failure documented by every prior sync PR (#60, #77, #103, #135, #167). With no other warnings, every content and nav validation passes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SAJucHo2Qx4qVUgiyNVLwy
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review window
Prior "docs: sync documentation with recent changes" PR: #167, created 2026-09-23T12:17:29Z, merged 2026-09-23T13:32:11Z. This reviews everything merged into
mainsince then: #168-#179 (12 PRs).That window landed the hosted Hugging Face Space (Dockerfile, publish workflow, link-preview card, commit-pinned rebuilds), several playground features (first-run key prompt, database switcher, a new Pipeline page, per-step model selection with per-provider keys), and two engine refactors (dropping the plan's
ordinalfields, folding the standaloneglobal_plannernode into the decomposer). Each of those 12 PRs already updated most of its own docs as part of its commits — three parallel audits (hosted-demo/deploy docs, playground docs, architecture docs) cross-checked what remained against the current code onmain, not just the PR diffs. This PR covers what survived that self-documentation.Corrections
docs/architecture/invariants.md: dropped the "Relation Schemas Have Unique Column Names" section (and its listing under the "State" category) — it referencedRelationSchema.validate_unique_columns(), butRelationSchemaandColumnSpecwere deleted entirely by refactor(pipeline): build the execution DAG in the decomposer instead of its own node #177 and no longer exist anywhere inpackages/.docs/architecture/failure_recovery.md(two spots) anddocs/architecture/graph_state.md: dropped "global planner" from the lists of nodes that don't retry / have no local recovery, and dropped "DAG hashes" from whatGraphStatecarries. refactor(pipeline): build the execution DAG in the decomposer instead of its own node #177 deleted the standaloneglobal_plannerpipeline node (folded intodecomposer/dag.py, called fromdecomposer/node.py) and removedExecutionDAG.dag_id/.content_hash— confirmed neither field exists inpackages/nl2sql/src/nl2sql/execution/dag.pyany more.docs/deployment/hosted-demo.mdanddeploy/huggingface/README.md: the query-timeout row said60s/60.packages/nl2sql/src/nl2sql/cli/generators/env/templates.py:24-26writesGLOBAL_TIMEOUT_SEC=300into every demo project's.env.demo(with a comment explaining the 60s library default caused every livenl2sql demoquestion to hitPIPELINE_TIMEOUT), anddeploy/huggingface/Dockerfile'sENVblock never overrides it back down — so 300s is the actual effective default, both locally and on the hosted Space. Also noted inhosted-demo.mdthat a push to the workflow file itself (.github/workflows/publish_space.yml) redeploys the Space, per its ownpaths:trigger, which the prose previously left out.web/playground/README.md: the dev-proxy route list was missingGET /api/pipeline(added in feat(playground): a Pipeline page showing what each step does #171, fetched byApp.jsx:122/190and served bycli/demo/playground/app.py); thenpm testparagraph named every tested helper module exceptsrc/pipeline.js,src/hostedKey.jsandsrc/hostedModels.js(each has its own*.test.js, added in feat(playground): a Pipeline page showing what each step does #171/feat(playground): choose a model per step in the hosted demo, with a key per provider #173/feat(demo): hosted mode so a public demo can take each visitor's own key #165); and the "Scope" section's line count forsrc/router.js(110) was stale — it's 119 lines now.docs/getting_started/demo.md: the Pipeline page section said "the other nine are ordinary code."packages/nl2sql/src/nl2sql/pipeline/steps.py'sPIPELINE_STEPSlists 13 steps total, andllm/providers.py'sLLM_AGENTSnames 5 as model-decided — leaving eight, not nine.docs/configuration/llm.md: "the playground's Settings panel" → "Settings page", for consistency with the rest of the same paragraph and file, which correctly call it a page elsewhere (Settings has been its own routed page,#/settings, since an earlier PR).Verification
main, not just the PR diffs.pip install -r requirements-docs.txt && python -m mkdocs build --strict: fails with exactly one warning —mkdocs-mermaid2-plugincannot reachunpkg.comto verify the mermaid.js CDN URL, rejected by this sandbox's outbound network policy (connect_rejected, gateway 403). This is the identical sandbox-only failure documented by every prior sync PR (docs: sync documentation with recent changes #60, docs: sync documentation with recent changes #77, docs: sync documentation with recent changes #103, docs: sync documentation with recent changes #135, docs: sync documentation with recent changes #167). With no other warnings, every content and nav validation passes.Not touched
CHANGELOG.mdand version numbers (release-please owns those).🤖 Generated with Claude Code
https://claude.ai/code/session_01SAJucHo2Qx4qVUgiyNVLwy
Generated by Claude Code