Repository navigation
fix: reject mismatched TCMP/TSEL physical shapes - #291
Merged
Merged
Conversation
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #290.
TCMPoperands whose physicalRows x ColsorBFractallayout differs.TCMPpredicate destinations whose physical shape/layout differs from the source.TSELmask/true-source physical shape/layout mismatches.ISA basis
The current PTO-SPEC normative comparison contract requires logical shape matching, including physical rows/columns, valid rows/columns, and layout. This patch moves the mismatch diagnostic from model-time assertion to the TileOP API compile-time boundary.
Validation
python3 test/test_issue290_compare_select_shape.py -v: 2/2 passpython3 test/test_v058_engine_contract.py: 59/59 passTCMP/TSELfixture compilesTCMPfixture is rejected with the expected diagnosticgit diff --checkpassThe broader local frontend gate remains blocked by the pre-existing
Shared handle materialized to memorycheck, unrelated to this change.