Repository navigation
test: guard narrow TCMP constructors and mandatory LB0 codegen - #293
Merged
Merged
Conversation
VV0003
enabled auto-merge (squash)
October 26, 2026 06:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes compiler/API regression coverage for LinxISA/llvm-project#138 on top of merged #291.
Root cause and companion LLVM fix
Machine-code inspection found a real LLVM bug: mandatory non-transport LB0=1 remained a register operand while its defining ADDI was erased. LLVM commit
f3855334d201ondev-llvm15_56now folds it to explicitC.B.DIMI 1, ->lb0instead. Optional default dimensions retain elision. This is a functional codegen fix, not a disassembly-only change. #291 already rejects incompatible physical TCMP/TSEL schemas.ISA basis
PTO normative
asl/tile/elementwise-tile-tile/logical/TCMP.aslandasl/tile/model/legality/dtype-layout.asl: logical shape includes physical rows/columns, valid rows/columns and layout; non-transport LB0 is required. Runtime valid-region equality/range remains the caller contract.Validation
c150817reproduces unrelatedtest_element_tile_api.test_reject_unsupported_dtypeandtest_weight_tload_contract.test_weight_bundle_uses_shared_nk_contractfailures.git diff --checkpass. No SSM end-to-end execution is claimed.Closes LinxISA/llvm-project#138