Skip to content

Fix macOS reactor close test timing - #33

Merged
treeform merged 1 commit into
masterfrom
fix-macos-reactor-close
Oct 1, 2026
Merged

treeform merged 1 commit into
masterfrom
fix-macos-reactor-close

Conversation

@treeform

@treeform treeform commented Oct 1, 2026

Copy link
Copy Markdown
Owner

The reactor close test can fail on macOS when the client's disconnect packet arrives after the server's first nonblocking tick. Poll for up to 100 ticks with a 1 ms pause, keep the server's clock fixed so connection timeout cannot satisfy the assertion, and verify the disconnected connection ID.

Reproduced the original failure locally with Nim 2.2.6 on macOS. This fixes the Netty package failure reported in Nim's macOS packages job.

Validation on macOS:

  • nim check tests/test_hardening.nim passed.
  • 500 consecutive hardening suite runs passed.
  • Main and time-series suites passed.
  • A negative control that suppresses the disconnect packet failed at the expected dead-connection assertion.

@treeform
treeform merged commit 39c9575 into master Oct 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant