Fix UDP test synchronization across ticks - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS build fails at
c2s.sendParts.len < 122when the first ACK has not arrived by the next client tick. UDP sends and peer ticks do not guarantee that data or ACKs are immediately readable. The failure was reproduced locally from the original window test.Wait for observable progress with a thirty-second monotonic deadline in the main suite's message, ACK, connection, and disconnect checks. The window test now explicitly checks that another sender tick cannot advance the queue before the server produces ACKs, then pumps both peers until both messages arrive and every part is acknowledged. It checks the byte limit on every sender tick and validates payloads and sequence numbers while accumulating messages across ticks.
The large-message checks now require delivery and acknowledgements within the deadline and report transfer duration, instead of accepting no messages or waiting for a connection timeout. The remote disconnect check freezes protocol time so a timeout cannot satisfy it.
Validation on macOS with Nim 2.2.12, matching CI:
nim checkpassed for the main and hardening suites; all three suites passed.nettyMagicSleepdisabled.Fixes the failure in the macOS master build after #33. No runtime behavior changes.