Skip to content

Fix macOS reactor close test timing #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
treeform merged 1 commit into from
Oct 1, 2026
Merged

Fix macOS reactor close test timing #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/test_hardening.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,8 @@ block:
# close() tears down the socket and is idempotent.
echo "Testing reactor close"
var server = newReactor("127.0.0.1", nextPort())
# Keep time fixed so only a disconnect packet can remove the connection.
server.debug.tickTime = 1.0
var client = newReactor()
var c2s = client.connect(server.address)
client.send(c2s, "bye")
Expand All @@ -330,8 +332,14 @@ block:
client.tick()
client.close()

server.tick()
# Local UDP delivery can take more than one tick on macOS.
for i in 0 ..< 100:
server.tick()
if server.deadConnections.len > 0:
break
sleep(1)
doAssert server.deadConnections.len == 1
doAssert server.deadConnections[0].id == c2s.id
doAssert server.connections.len == 0
server.close()
doAssert server.socket == nil
Expand Down
Loading