Skip to content

Add the SDK quickstart samples - #7

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:move-quickstarts-to-samples
Oct 20, 2026
Merged

brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:move-quickstarts-to-samples

Conversation

@brionmario

@brionmario brionmario commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Purpose

Makes this repository the home of the SDK quickstarts (thunder-id/thunderid#5904). Each quickstart moves here from its SDK repository, keeps its README and setup instructions, and now runs on its own against the published SDK release.

Sample Depends on
quickstarts/ios ios-sdks from 1.4.0 (SwiftPM and the Xcode project)
quickstarts/android com.github.thunder-id:android-sdks:v1.4.0 (JitPack)
quickstarts/flutter thunderid_flutter: ^1.2.0
quickstarts/react @thunderid/react 1.4.0, @thunderid/react-router 1.3.0
quickstarts/vue @thunderid/vue 1.4.0
quickstarts/nextjs, quickstarts/nuxt, quickstarts/browser, quickstarts/express, quickstarts/node the matching @thunderid/* 1.3.0

Approach

  • Layout: the quickstarts sit under quickstarts/<platform>, so they are released as sample/quickstarts/<platform>/v*.
  • Samples: copied from each SDK repository's tracked files only. Local workspace links (workspace:*, path: ../.., includeBuild, XCLocalSwiftPackageReference) are replaced with the published releases. Every app version starts at 0.0.0, like the existing samples did before their first release.
  • JS quickstarts: each now has its own pnpm-lock.yaml, .gitignore, and pnpm-workspace.yaml (allowBuilds). nextjs carries over the postcss override and nuxt the node-forge/braces audit ignores from javascript-sdks, each with its justification. prepare-dev.cjs no longer rewrites workspace:* deps, since there are none. StackBlitz badges now point here.
  • PR builder: discovery finds a sample's stack by the manifest at its root (package.json, pubspec.yaml, settings.gradle.kts, Package.swift). New Flutter (analyze + debug APK), Android (assembleDebug) and iOS (swift build on macOS) jobs join the Node.js one. The Node.js job now runs format:check/lint/build only where a sample defines them, because the server quickstarts have no build step. This also brings integrations/flutter-app-auth under CI.
  • Release: the per-sample jobs become one matrix job planned from the checked sample_* inputs (14 inputs in total). Commit, tag, pack and release steps are unchanged. bump-version now also bumps versionName/versionCode in build.gradle.kts and MARKETING_VERSION/CURRENT_PROJECT_VERSION in project.pbxproj. The iOS Info.plist reads both from the project.
  • README: lists the quickstarts.

Verified locally: every JS quickstart installs, passes pnpm audit --audit-level=high, and builds or loads against the published packages. quickstarts/android runs assembleDebug against JitPack v1.4.0. quickstarts/flutter passes flutter analyze and flutter build apk --debug against 1.2.0. quickstarts/ios builds with xcodebuild (simulator) and swift build against 1.4.0. The new bump logic was tested on Gradle and pbxproj fixtures, and the release plan step on sample inputs. The workflows themselves have not run on GitHub yet.

Related Issues

Related PRs

Merge order: #7 first. The SDK PRs' E2E suites and sample builds fetch the quickstarts from samples main, so they fail at the fetch step until it merges. Re-run their checks afterwards.

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

Move the iOS, Android, Flutter, React, Vue, Next.js, Nuxt, Browser, Express and Node.js quickstarts here from the SDK repositories. Each sample now depends on the published SDK release, is built by the PR builder, and is released through the release workflow, which now runs as one matrix job.

Refs thunder-id/thunderid#5904

Signed-off-by: Brion <info@brionmario.com>
@brionmario
brionmario force-pushed the move-quickstarts-to-samples branch from da4d311 to fc75389 Compare October 19, 2026 17:58
@brionmario
brionmario merged commit 70047f8 into thunder-id:main Oct 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants