Repository navigation
Move the quickstart to the samples repository and add a playground - #39
Merged
brionmario merged 1 commit intoOct 21, 2026
Merged
Conversation
🔀 Cross-SDK feature parity, ports raisedThis pull request is labelled Ports (DO NOT EDIT)
3 of 3 sibling SDKs accounted for. Every sibling SDK is accounted for. The contract is in the SDK development specification. |
This was referenced Oct 19, 2026
Merged
Merged
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brionmario
force-pushed
the
move-quickstarts-to-samples
branch
2 times, most recently
from
October 20, 2026 05:02
fc49f95 to
7ab1db2
Compare
brionmario
force-pushed
the
move-quickstarts-to-samples
branch
from
October 20, 2026 12:52
7ab1db2 to
1eb1d3b
Compare
The quickstart now lives in thunder-id/samples and uses the published SDK. The E2E suite and the PR builder fetch it from there and point it at this checkout through tests/e2e/scripts/prepare-sample.sh. The release no longer attaches a quickstart archive. playground/ takes its place for exercising the SDK from source: capability checks, a component explorer with Compose snippets, and a session inspector, linted and built by the PR builder. Refs thunder-id/thunderid#5904 Refs thunder-id/thunderid#5919 Signed-off-by: Brion <info@brionmario.com>
brionmario
force-pushed
the
move-quickstarts-to-samples
branch
from
October 20, 2026 12:58
1eb1d3b to
0d37ebe
Compare
DonOmalVindula
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Moves the Android quickstart to thunder-id/samples (thunder-id/thunderid#5904).
Approach
THUNDERID_SAMPLES_REFpicks another branch or tag (needed when an SDK change and a sample change land together),THUNDERID_SAMPLES_DIRuses a local samples checkout (copied, never modified), andTHUNDERID_SAMPLES_REPOoverrides the repository. The fetched copy is gitignored.tests/e2e/scripts/prepare-sample.sh(plus a.ps1forrun-e2e.ps1) copiesquickstarts/androidintotests/e2e/.samplesand adds anincludeBuildof this checkout that substitutescom.github.thunder-id:android-sdks. Thebuild-samplejob and the E2E runners both use it.AGENTS.md,README.mdand the E2E README point at the new location.Verified locally:
./gradlew ktlintCheckand./gradlew build -x testpass. The prepared sample'sassembleDebugresolvescom.github.thunder-id:android-sdks:v1.4.0 -> project :android. The.ps1scripts were parsed with pwsh but not executed. The Maestro suite was not run.Playground
playground/replaces the quickstart for exercising the SDK from source (thunder-id/thunderid#5919). It is a standalone Jetpack Compose build that usesincludeBuild("..")to substitutedev.thunderid:androidwith this checkout:The new
build-playgroundjob runs./gradlew ktlintCheck assembleDebuginplayground/. It was run on an emulator against a local server. Setup is inplayground/README.md.Shown as unavailable because the SDK has no API for them yet: biometric unlock and organizations. There is also no public read of the ID token, refresh token or expiry, no forced refresh, no event emitter, and no SDK version constant. The playground reads tokens through a storage adapter, so it depends on the SDK's internal key names.
Screenshots
Android emulator (API 36). The Checks tab is from a run without
config.properties; Components and Session are from an earlier run against the local server, whose seeded Console app does not allow app-native flows.Related Issues
Related PRs
Merge order: thunder-id/samples#7 first. The SDK PRs' E2E suites and sample builds fetch the quickstarts from samples
main, so they fail at the fetch step until it merges. Re-run their checks afterwards.Checklist
breaking changelabel added.parity/prs-raisedorparity/prs-not-neededadded.parity/prs-raised, the port links are posted as a reply on the parity check's comment.Security checks