Repository navigation
Add the Better Auth sample and fix sample releases and the vite advisory - #11
Merged
brionmario merged 3 commits intoOct 21, 2026
Conversation
…visory The new launch-editor advisory (fs.existsSync existence check bypass on Windows) reaches self-care/account through its vite 8.0.16 devDependency, failing pnpm audit --audit-level=high in the PR builder for every pull request. vite 8.3.4 is patched (>=8.1.6). Signed-off-by: Brion <info@brionmario.com>
Move it here from thunder-id/javascript-sdks as integrations/better-auth-nextjs. It now depends on the published @thunderid/better-auth release, carries its own lockfile and the Next.js postcss override, is built by the PR builder and can be released through the release workflow. Refs thunder-id/thunderid#5904 Signed-off-by: Brion <info@brionmario.com>
Releasing many samples at once ran every matrix job's version-bump push against main together, and the fixed 3 to 12 second backoff gave up after five attempts, failing the Express, Vue and Flutter quickstart releases. Run at most four releases at a time and retry up to ten times with a randomized wait. Refs thunder-id/thunderid#5904 Signed-off-by: Brion <info@brionmario.com>
This was referenced Oct 21, 2026
Merged
thiva-k
approved these changes
Oct 21, 2026
6 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Combines #8, #9 and #10 into one pull request, one commit each, so they land together (thunder-id/thunderid#5904).
fs.existsSync()existence check being bypassable on Windows, reachesself-care/accountthrough itsvite8.0.16 devDependency. It failspnpm audit --audit-level=highin the PR builder for every pull request.vitemoves to 8.3.4, which is patched (>=8.1.6) and still accepted by@vitejs/plugin-react6.0.2.integrations/better-auth-nextjs.@thunderid/better-auth0.1.1.postcssoverride the Next.js quickstart carries.pnpm install.sample_better_auth_nextjsinput, and the root README lists it.mainat once and gave up after five fixed-backoff attempts. Releases now run at most four at a time and retry up to ten times with a randomized wait.Approach
See each commit. The second and third commits touch different parts of
.github/workflows/release.yml. The combined workflow has 15 inputs, and its plan step was checked locally with the Better Auth and React samples selected.Verified locally:
self-care/account:pnpm audit --audit-level=high(2 low only),format:check,lint,build.integrations/better-auth-nextjs:pnpm install --frozen-lockfile,pnpm audit --audit-level=high(no known vulnerabilities), andpnpm buildwith and without a.env.Related Issues
Related PRs
Merge order: this PR before thunder-id/javascript-sdks#126 and thunder-id/thunderid#5910.
Checklist
breaking changelabel added.Security checks