Repository navigation
Bump vite in the self-care account sample to fix the launch-editor advisory - #10
Closed
brionmario wants to merge 1 commit into
Closed
brionmario wants to merge 1 commit into
brionmario wants to merge 1 commit into
Conversation
…visory The new launch-editor advisory (fs.existsSync existence check bypass on Windows) reaches self-care/account through its vite 8.0.16 devDependency, failing pnpm audit --audit-level=high in the PR builder for every pull request. vite 8.3.4 is patched (>=8.1.6). Signed-off-by: Brion <info@brionmario.com>
5 of 11 tasks
Member
Author
|
Combined into #11 together with the other sample changes, one commit each. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A new high-severity advisory, launch-editor's
fs.existsSync()existence check being bypassable on Windows, reachesself-care/accountthrough itsvite8.0.16 devDependency (@vitejs/plugin-react>vite).pnpm audit --audit-level=highin the PR builder now fails theself-care/accountjob on every pull request, for example #9.Approach
Bump the direct
vitedevDependency from 8.0.16 to 8.3.4, which is in the patched range (>=8.1.6).@vitejs/plugin-react6.0.2 already acceptsvite ^8.0.0, so no other change is needed and no override is required.Verified locally in
self-care/account:pnpm install,pnpm audit --audit-level=high(now 2 low only),pnpm format:check,pnpm lintandpnpm buildall pass.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks