Skip to content

chore: remove transifex from the translation workflow - #1615

Merged
ovitrif merged 1 commit into
masterfrom
chore/drop-transifex
Oct 20, 2026
Merged

ovitrif merged 1 commit into
masterfrom
chore/drop-transifex

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Refs: #1489
Twin: synonymdev/bitkit-ios#1043

This PR removes Transifex from the translation workflow. Translations already live in this repository, and the team agreed in #bitkit-native to maintain them in feature PRs instead of syncing through Transifex.

Description

  • Removes .tx/config, scripts/pull-translations.sh and scripts/push-translations.sh, and the just translations recipe with its help lines.
  • Removes TX_TOKEN from .env.example and the README setup line.
  • Replaces the README's Localization section: translations live in values-*/strings.xml, and a PR that adds or changes an English string updates every shipped locale.
  • Adds the same rule to AGENTS.md.
  • Drops the Transifex mention from the gift-card-category-titles.xml journey notes.

Out of Scope

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

N/A

@ovitrif ovitrif added this to the 3.1.0 milestone Oct 20, 2026
@ovitrif ovitrif self-assigned this Oct 20, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T14:08:21.777195Z 1a50635 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ovitrif
ovitrif requested review from a team, ben-kaufman and pwltr and removed request for a team October 20, 2026 14:07
@github-actions

Copy link
Copy Markdown
Contributor

Regtest APK

Built from 1a50635 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Removes Transifex tooling and makes feature PRs responsible for translations.

  • Developers update app translations in feature PRs instead of syncing them through Transifex.

No actionable issues found. No runtime checks were run.

Translation checks and fuller agent guidance were explicitly deferred by ovitrif to #1489.

Reviews (1) · Last reviewed commit: "chore: remove transifex from the transla..." · Reviewed by Greptile

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Removes the Transifex config, the pull/push scripts, the just translations recipe and TX_TOKEN, and states the in-repo translation rule in the README and AGENTS.md. Reviewed 1a50635, light tier, reasoned from the code and CI.

What I checked, and 3 candidates I ruled out

Read in full: the whole diff; Justfile at the PR head
CI: build, lint, detekt and e2e-status green; the e2e jobs skipped as expected for a change with no app code

Ruled out

  • A leftover caller of the removed scripts or recipe: git grep -i -E 'transifex|tx_token|pull-translations|push-translations|just translations|\.tx/' at the PR head finds only the new AGENTS.md line that names Transifex on purpose; no workflow, script or doc still calls them.
  • A broken just list: the three translations lines are removed from the help list along with the recipe, and the remaining continuation lines still end in \ up to "clean".
  • A stale README pointer: the setup step and the "common commands" sentence no longer mention TX_TOKEN or just translations pull.

Merge confidence: 5/5, CI green and the change is docs, config and dead scripts a test would not apply to.

@ovitrif
ovitrif merged commit ca3232a into master Oct 20, 2026
16 checks passed
@ovitrif
ovitrif deleted the chore/drop-transifex branch October 20, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants