Repository navigation
chore: remove transifex from the translation workflow - #1615
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
[Medium impact] This PR appears safe to merge. SummaryRemoves Transifex tooling and makes feature PRs responsible for translations.
No actionable issues found. No runtime checks were run. Translation checks and fuller agent guidance were explicitly deferred by Reviews (1) · Last reviewed commit: "chore: remove transifex from the transla..." · Reviewed by Greptile |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Removes the Transifex config, the pull/push scripts, the just translations recipe and TX_TOKEN, and states the in-repo translation rule in the README and AGENTS.md. Reviewed 1a50635, light tier, reasoned from the code and CI.
What I checked, and 3 candidates I ruled out
Read in full: the whole diff; Justfile at the PR head
CI: build, lint, detekt and e2e-status green; the e2e jobs skipped as expected for a change with no app code
Ruled out
- A leftover caller of the removed scripts or recipe:
git grep -i -E 'transifex|tx_token|pull-translations|push-translations|just translations|\.tx/'at the PR head finds only the newAGENTS.mdline that names Transifex on purpose; no workflow, script or doc still calls them. - A broken
just list: the threetranslationslines are removed from the help list along with the recipe, and the remaining continuation lines still end in\up to"clean". - A stale README pointer: the setup step and the "common commands" sentence no longer mention
TX_TOKENorjust translations pull.
Merge confidence: 5/5, CI green and the change is docs, config and dead scripts a test would not apply to.
Refs: #1489
Twin: synonymdev/bitkit-ios#1043
This PR removes Transifex from the translation workflow. Translations already live in this repository, and the team agreed in #bitkit-native to maintain them in feature PRs instead of syncing through Transifex.
Description
.tx/config,scripts/pull-translations.shandscripts/push-translations.sh, and thejust translationsrecipe with its help lines.TX_TOKENfrom.env.exampleand the README setup line.values-*/strings.xml, and a PR that adds or changes an English string updates every shipped locale.AGENTS.md.gift-card-category-titles.xmljourney notes.Out of Scope
Design
N/A — no UI changes.
Preview
N/A
QA Notes
Journeys
N/A — no user-visible behaviour change.
Manual Tests
N/A
Automated Checks
N/A