Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

# GITHUB_ACTOR=
# GITHUB_TOKEN=
# TX_TOKEN=

# KEYSTORE_FILE=
# KEYSTORE_PASSWORD=
Expand Down
8 changes: 0 additions & 8 deletions .tx/config

This file was deleted.

1 change: 1 addition & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ suspend fun getData(): Result<Data> = withContext(Dispatchers.IO) {
- ALWAYS add business logic to repository layer via methods returning `Result<T>` and use it in ViewModels
- ALWAYS order upstream architectural data flow this way: `UI -> ViewModel -> Repository -> RUST` and vice versa for downstream
- ALWAYS add new localizable string resources in alphabetical order in `strings.xml`
- ALWAYS add or update the translation in every `values-*/strings.xml` in the same PR when adding or changing an English string; translations live in this repository, not in Transifex
- NEVER add string resources for strings used only in dev settings screens and previews and never localize acronyms
- ALWAYS use template in `.github/pull_request_template.md` for PR descriptions
- ALWAYS reference test files in PR descriptions/QA Notes by bare file name only (e.g. `HwWalletRepoTest.kt`), NEVER the full path; only when two referenced test files share the same name, prefix the shortest leading path segment(s) that disambiguate them (e.g. `repositories/FooTest.kt` vs `viewmodels/FooTest.kt`)
Expand Down
6 changes: 0 additions & 6 deletions Justfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ list:
"lint" \
"lint baseline" \
"format" \
"translations pull" \
"translations push source" \
"translations push all" \
"e2e [network|no geo|TASK] [TASK]" \
"changelog [all|next|hotfix]" \
"clean"
Expand Down Expand Up @@ -193,9 +190,6 @@ lint target="":
format:
{{ gradle }} detekt --auto-correct --rerun-tasks

translations action value="":
{{ if action == "pull" { "./scripts/pull-translations.sh" } else if action == "push" { if value == "source" { "tx push --source" } else if value == "all" { "./scripts/push-translations.sh" } else { error("usage: just translations pull|push source|push all") } } else { error("usage: just translations pull|push source|push all") } }}

e2e mode="" value="" task="assembleDevRelease":
{{ if mode == "" { "E2E=true " + gradle + " " + task } else if mode == "network" { "E2E=true E2E_BACKEND=network " + gradle + " " + if value == "" { task } else { value } } else if mode == "no" { if value == "geo" { "GEO=false E2E=true " + gradle + " " + task } else { error("usage: just e2e no geo [TASK]") } } else { "E2E=true " + gradle + " " + mode } }}

Expand Down
42 changes: 3 additions & 39 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ Install `just` ([more options](https://github.com/casey/just#packages)):

Set up local env:
- `just init`
- Uncomment only the values you need in the fresh `.env` file, such as `GITHUB_ACTOR`, `GITHUB_TOKEN`, `TX_TOKEN`, and E2E build settings.
- Uncomment only the values you need in the fresh `.env` file, such as `GITHUB_ACTOR`, `GITHUB_TOKEN`, and E2E build settings.

Run `just list` to see available commands. The common ones are `just init`, `just compile`, `just run`, `just build`, `just release`, `just test`, `just lint`, and `just translations pull`. `just run` prefers a physical device and falls back to an emulator.
Run `just list` to see available commands. The common ones are `just init`, `just compile`, `just run`, `just build`, `just release`, `just test`, and `just lint`. `just run` prefers a physical device and falls back to an emulator.

### Trezor Bridge In Android Studio

Expand Down Expand Up @@ -122,43 +122,7 @@ just test android # run

## Localization

### Pulling Translations

To pull the latest translations from Transifex:

1. **Install Transifex CLI** (if not already installed):
- Follow the installation instructions: [Transifex CLI Installation](https://developers.transifex.com/docs/cli)

2. **Authenticate with Transifex** (if not already configured):
- Set the `TX_TOKEN` environment variable with your API token:
```sh
export TX_TOKEN="YOUR_API_TOKEN_HERE"
```
- You can get your API token from [Transifex account settings](https://www.transifex.com/user/settings/api/)
- Add it to `~/.zshrc` or other shell rc file to persist across sessions

3. **Pull translations**:
```sh
just translations pull
```

### Pushing Source Strings

When you add or modify translation keys in the EN source file, push them to Transifex:

```sh
just translations push source
```

To intentionally round-trip local source and translation files back to Transifex, use `just translations push all`.

### Translation Workflow

1. **Add/modify strings** in `app/src/main/res/values/strings.xml`
2. **Push to Transifex:** `just translations push source`
3. **Translators** work on translations in Transifex
4. **Pull translations:** `just translations pull`
5. **Commit** the updated translation files
Translations live in this repository, in `app/src/main/res/values-*/strings.xml`. A PR that adds or changes an English string in `app/src/main/res/values/strings.xml` updates every shipped locale in the same PR.

## Build

Expand Down
2 changes: 1 addition & 1 deletion journeys/shop/gift-card-category-titles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
an `other__shop__categories__*` key yet, so every row reads English in every shipped locale
either way. A pseudolocale cannot close the gap: `androidResources.localeFilters`
(`app/build.gradle.kts:276`) keeps only the 16 shipped locales, so `en-XA` resources are
stripped. Once the Transifex pull lands the German strings, replace the German step below with
stripped. Once the German strings land, replace the German step below with
assertions on concrete translated titles ("Food Delivery" and "Health &amp; Beauty" rows plus
the web view top bar) and drop the English fallback allowance; that is what makes this journey
discriminate. "VoIP" is not translatable and stays "VoIP" in every locale.
Expand Down
286 changes: 0 additions & 286 deletions scripts/pull-translations.sh

This file was deleted.

Loading
Loading