Skip to content

chore: remove transifex from the translation workflow - #1043

Merged
ovitrif merged 1 commit into
masterfrom
chore/drop-transifex
Oct 20, 2026
Merged

ovitrif merged 1 commit into
masterfrom
chore/drop-transifex

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Refs: #936
Twin: synonymdev/bitkit-android#1615

This PR removes Transifex from the translation workflow. Translations already live in this repository, and the team agreed in #bitkit-native to maintain them in feature PRs instead of syncing through Transifex.

Description

  • Removes .tx/config, scripts/pull-translations.sh and the tx entry in .gitignore.
  • Replaces the README's "Pulling Translations" steps: translations live in *.lproj/Localizable.strings, and a PR that adds or changes an English string updates every shipped locale.
  • Updates AGENTS.md: the two bitkit-transifex-sync notes become the same rule.

Out of Scope

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

N/A

@ovitrif ovitrif added this to the 3.1.0 milestone Oct 20, 2026
@ovitrif ovitrif self-assigned this Oct 20, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T14:08:42.836932Z 2ff781f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ovitrif
ovitrif requested review from a team, coreyphillips and pwltr and removed request for a team October 20, 2026 14:07
@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Removes Transifex tooling and moves translation updates into feature PRs.

  • Contributors update translations alongside English strings in each pull request.

No actionable issues found. ovitrif explicitly deferred translation validation and full agent instructions to #936.

Reviews (1) · Last reviewed commit: "chore: remove transifex from the transla..." · Reviewed by Greptile

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Removes the Transifex config, scripts/pull-translations.sh and the tx ignore entry, and rewrites the README and both AGENTS.md notes to the in-repo translation rule. Reviewed 2ff781f, light tier, reasoned from the code and CI.

What I checked, and 3 candidates I ruled out

Read in full: the whole diff
CI: validate, e2e-status and Greptile green; Run Tests and Run Integration Tests pending; SwiftFormat red

Ruled out

  • SwiftFormat failing because of this PR: the PR touches no .swift file, and the same check is red on master at f898732 with the same kinds of finding (wrapIfStatementBodies, repeatedGuard, wrap; "3/831 files require formatting"). That is pre-existing formatting debt on the base branch.
  • A leftover caller of the removed script: git grep -i -E 'transifex|tx_token|pull-translations|\.tx/|bitkit-transifex' at the PR head finds nothing.
  • The README losing the validation step: only the "Pulling Translations" steps go; the "Validating Translations" section and node scripts/validate-translations.js stay, and the validate job passes.

Merge confidence: 4/5, no findings and nothing to test in a docs and tooling change, but SwiftFormat is red, from master and not from this PR.

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. No issues found.

  • Translations stay in Bitkit/Resources/Localization/*.lproj/Localizable.strings, updated by the PR that changes an English string. scripts/validate-translations.js and its workflow remain.
  • Grepping the head for transifex, pull-translations, .tx/, tx_token and tx pull finds nothing, including .github, scripts and .agents/commands/release.md / pr.md.
  • No workflow ever called pull-translations.sh, so the release flow is unaffected. The /release command's release-notes translation doesn't use Transifex.
  • The Android twin synonymdev/bitkit-android#1615 is already merged.
  • The red SwiftFormat check comes from master files that #1040 fixes.

Device gate: no device check needed (tooling and docs only); perf: not relevant; l10n: no UI text changed.

@ovitrif
ovitrif merged commit cf4d878 into master Oct 20, 2026
19 of 21 checks passed
@ovitrif
ovitrif deleted the chore/drop-transifex branch October 20, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants