Repository navigation
chore: remove transifex from the translation workflow - #1043
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Medium impact] This PR appears safe to merge. SummaryRemoves Transifex tooling and moves translation updates into feature PRs.
No actionable issues found. ovitrif explicitly deferred translation validation and full agent instructions to #936. Reviews (1) · Last reviewed commit: "chore: remove transifex from the transla..." · Reviewed by Greptile |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Removes the Transifex config, scripts/pull-translations.sh and the tx ignore entry, and rewrites the README and both AGENTS.md notes to the in-repo translation rule. Reviewed 2ff781f, light tier, reasoned from the code and CI.
What I checked, and 3 candidates I ruled out
Read in full: the whole diff
CI: validate, e2e-status and Greptile green; Run Tests and Run Integration Tests pending; SwiftFormat red
Ruled out
- SwiftFormat failing because of this PR: the PR touches no
.swiftfile, and the same check is red onmasteratf898732with the same kinds of finding (wrapIfStatementBodies,repeatedGuard,wrap; "3/831 files require formatting"). That is pre-existing formatting debt on the base branch. - A leftover caller of the removed script:
git grep -i -E 'transifex|tx_token|pull-translations|\.tx/|bitkit-transifex'at the PR head finds nothing. - The README losing the validation step: only the "Pulling Translations" steps go; the "Validating Translations" section and
node scripts/validate-translations.jsstay, and thevalidatejob passes.
Merge confidence: 4/5, no findings and nothing to test in a docs and tooling change, but SwiftFormat is red, from master and not from this PR.
jvsena42
left a comment
There was a problem hiding this comment.
Approving. No issues found.
- Translations stay in
Bitkit/Resources/Localization/*.lproj/Localizable.strings, updated by the PR that changes an English string.scripts/validate-translations.jsand its workflow remain. - Grepping the head for
transifex,pull-translations,.tx/,tx_tokenandtx pullfinds nothing, including.github,scriptsand.agents/commands/release.md/pr.md. - No workflow ever called
pull-translations.sh, so the release flow is unaffected. The/releasecommand's release-notes translation doesn't use Transifex. - The Android twin synonymdev/bitkit-android#1615 is already merged.
- The red SwiftFormat check comes from master files that #1040 fixes.
Device gate: no device check needed (tooling and docs only); perf: not relevant; l10n: no UI text changed.
Refs: #936
Twin: synonymdev/bitkit-android#1615
This PR removes Transifex from the translation workflow. Translations already live in this repository, and the team agreed in #bitkit-native to maintain them in feature PRs instead of syncing through Transifex.
Description
.tx/config,scripts/pull-translations.shand thetxentry in.gitignore.*.lproj/Localizable.strings, and a PR that adds or changes an English string updates every shipped locale.AGENTS.md: the twobitkit-transifex-syncnotes become the same rule.Out of Scope
Design
N/A — no UI changes.
Preview
N/A
QA Notes
Journeys
N/A — no user-visible behaviour change.
Manual Tests
N/A
Automated Checks
N/A