fix(md2html): check curl exit status for network errors - #172
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For a local file or stdin, a network failure was not detected: gh-md-toc printed an
empty TOC and exited with code 0. With
--insertthe empty TOC replaced the existingone in the file.
gh_toc_md2htmlchecked$?afterrm -f "${gh_file_md}~~", which 8daa73c ("Skipheaders if end marker is present") inserted between the
curlcall and the check. So$?was the status ofrm -f, always 0, andXXNetworkErrorXXwas never returned.gh-md-toc: save thecurlexit status right after the call and check it insteadof
$?.tests/tests.bats: new testError for local file without network access. It sendscurlthroughHTTPS_PROXY=http://127.0.0.1:9(a closed port) and expects the"requires access to github API" message and a non-zero exit code.
Part of #167: this resolves the SC2181 warning.
Testing
tests pass.
shellcheck -e SC2008 gh-md-tocno longer reports SC2181; the other warnings frommake lint fails on shellcheck style and info warnings #167 are unchanged.