refactor(lint): fix shellcheck warnings - #173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #167 together with #172:
make lintpasses once both are merged.$(...). None of them containbackslashes, so the result is the same.
# shellcheck disable=SC2016above eachawkscript='{...}'assignment. The awk scripts are single-quoted on purpose so that
$0reaches awkunexpanded. The directive is set per assignment, not on the whole
ifblock.SC2181 is a real bug rather than a style issue and is fixed separately in #172.
No behavior changes.
Testing
--versionoutput and the--insertfooter (Added by: $(whoami), at: $(date)),which the tests do not cover, are the same as on
master.shellcheck -e SC2008 gh-md-tocreports only SC2181, which fix(md2html): check curl exit status for network errors #172 resolves.