Skip to content

fix(md2html): check curl exit status for network errors #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekalinin merged 1 commit into from
Sep 28, 2026
Merged

fix(md2html): check curl exit status for network errors #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gh-md-toc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,11 @@ gh_toc_md2html() {
-H "Content-Type:text/plain" \
-H "$AUTHORIZATION" \
"$URL")
local curl_status=$?

rm -f "${gh_file_md}~~"

if [ "$?" != "0" ]; then
if [ "$curl_status" != "0" ]; then
echo "XXNetworkErrorXX"
fi
if [ "$(echo "${OUTPUT}" | awk '/API rate limit exceeded/')" != "" ]; then
Expand Down
9 changes: 9 additions & 0 deletions tests/tests.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,3 +233,12 @@ test_help() {
assert_equal "${lines[8]}" "* [Title four is a particularly long title because of wrapping](#title-four-is-a-particularly-long-title-because-of-wrapping)"
assert_equal "${lines[9]}" " * [This is a test for long titles](#this-is-a-test-for-long-titles)"
}

@test "Error for local file without network access" {
# route curl through a closed port to simulate a network failure
HTTPS_PROXY=http://127.0.0.1:9 run $BATS_TEST_DIRNAME/../gh-md-toc tests/test\ directory/test_plussign.md
assert_fail

assert_equal "${lines[2]}" "Parsing local markdown file requires access to github API"
assert_equal "${lines[3]}" "Please make sure curl is installed and check your network connectivity"
}
Loading