fix(resolution): read a quoted Python annotation as a receiver type - #1770
Merged
Merged
Conversation
…1684) `def f(o: "Alpha")` is the same annotation as `def f(o: Alpha)` — a forward reference, and what every file under `from __future__ import annotations` writes — but the receiver-type pattern stopped at the quote, read no type, and `o.render()` produced no edge. Admit the quoted form.
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1684.
Problem
def f(o: "Alpha")is the same annotation asdef f(o: Alpha)— a forward reference, and what every file underfrom __future__ import annotationswrites — but the receiver-type pattern (\bo\b\s*:\s*([A-Z][\w.]*)) stopped at the quote, read no type, ando.render()produced no edge at all while the unquoted twin resolved toAlpha::render.Change
buildLocalReceiverTypePatterns(Python) admits the quoted form,o: "Alpha"/o: 'pkg.Alpha', tried before the unquoted pattern.resolveMethodOnTypestill validates the method exists on that type, so nothing new can be guessed.Evaluation of #1690
Upstream #1690 (danusha2345) had the correct fix and regression test, but was ~11 commits behind
mainand a full-file merge would have reverted later resolution fixes (NO_NESTED_FUNCTIONS/ #1729, lexical reachability / #1708–#1709). This PR lands the same surgical change on currentmain.Verification (Linux)
main:__tests__/python-quoted-annotation.test.tsfailed (expected [] to deeply equal ['Alpha::render']).__tests__/resolution.test.ts198/198 pass.