fix(lua): extract assigned function expressions - #1623
Closed
danusha2345 wants to merge 7 commits into
Closed
danusha2345 wants to merge 7 commits into
danusha2345 wants to merge 7 commits into
Conversation
danusha2345
force-pushed
the
fix/1616-lua-function-expressions
branch
from
August 28, 2026 07:03
2f0c630 to
aa77706
Compare
added 2 commits
September 8, 2026 11:12
…-expressions # Conflicts: # CHANGELOG.md
…-expressions # Conflicts: # CHANGELOG.md
Contributor
Author
|
Merged current |
…-expressions # Conflicts: # CHANGELOG.md
Contributor
Author
|
Merged current |
…-expressions # Conflicts: # CHANGELOG.md
Contributor
Author
|
Merged current |
…-expressions # Conflicts: # CHANGELOG.md
Contributor
Author
|
Merged current |
Owner
Owner
colbymchenry
added a commit
that referenced
this pull request
Sep 8, 2026
Apply upstream PR #1623 by danusha2345 (fix commit aa77706), which also addresses #1616, to the current main base. Preserve the upstream WASM and Rust implementations and regression coverage. Index assigned locals, table members, static string keys and nested callback tables as callable symbols, with calls owned by those symbols. Keep dynamic keys unguessed. Add #1650 to the Unreleased changelog and retain the existing re-index guidance without an extraction-version bump. Verified on Linux x64 with Node 22.19.0: - native kernel build, tsc, asset copy, executable CLI - issue repro: 3 nodes / 2 edges -> 4 nodes / 4 edges - EPR.PowerController::SyncHydroPower is indexed; its caller is client.lua - syncHydroPower depth-2 impact reaches client.lua - extraction/resolution/Lua parity: 844 tests passed (kernel expected) - forced-WASM Lua/Luau extraction/resolution: 20 tests passed Co-authored-by: Colby McHenry <colbymchenry@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1616.
Verification
npm run build:kernelnpm run buildnpm test -- --reporter=dot— 194 files, 3231 passed, 10 skipped