Optimize UI and Playwright dependency caching - #73183
Conversation
fee5584 to
7ce7af9
Compare
|
Hello @zozo123 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 6 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Playwright already rejects unknown browser names, so the case statement's fallback duplicated its validation, and the tests that exercised it only pinned workflow structure. The changed e2e workflow is covered by running the UI e2e jobs in CI.
7ce7af9 to
a6e44b8
Compare
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker f49bce0 v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
Avoid transferring duplicate UI node_modules archives by using the pnpm store cache already managed by setup-node. Keep frozen-lockfile installs and both UI test suites. For end-to-end tests, install only the selected Playwright browser, or all browsers when explicitly requested, including the required OS dependencies.
Validation: 11 focused tests pass locally; actionlint passes for both changed workflows. All 157 current GitHub checks are complete without failures. The tests exercise browser selection and invalid input handling; full browser execution remains covered by CI.
Split from #73124.
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-6) following the guidelines