Skip to content

Optimize UI and Playwright dependency caching - #73183

Merged
shahar1 merged 3 commits into
apache:mainfrom
zozo123:split/ui-playwright-cache
Sep 28, 2026
Merged

shahar1 merged 3 commits into
apache:mainfrom
zozo123:split/ui-playwright-cache

Conversation

@zozo123

@zozo123 zozo123 commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Avoid transferring duplicate UI node_modules archives by using the pnpm store cache already managed by setup-node. Keep frozen-lockfile installs and both UI test suites. For end-to-end tests, install only the selected Playwright browser, or all browsers when explicitly requested, including the required OS dependencies.

Validation: 11 focused tests pass locally; actionlint passes for both changed workflows. All 157 current GitHub checks are complete without failures. The tests exercise browser selection and invalid input handling; full browser execution remains covered by CI.

Split from #73124.


Was generative AI tooling used to co-author this PR?
  • Yes — Codex (GPT-6)

Generated-by: Codex (GPT-6) following the guidelines

@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @zozo123 - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 6 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@potiuk potiuk closed this Sep 25, 2026
@potiuk potiuk mentioned this pull request Sep 25, 2026
1 task done
@shahar1 shahar1 reopened this Sep 27, 2026
zozo123 and others added 3 commits September 27, 2026 23:53
Playwright already rejects unknown browser names, so the case statement's
fallback duplicated its validation, and the tests that exercised it only
pinned workflow structure. The changed e2e workflow is covered by running
the UI e2e jobs in CI.
@shahar1
shahar1 force-pushed the split/ui-playwright-cache branch from 7ce7af9 to a6e44b8 Compare September 27, 2026 20:54
@shahar1
shahar1 merged commit f49bce0 into apache:main Sep 28, 2026
156 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-3-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
❌ v3-3-test Commit Link

You can attempt to backport this manually by running:

cherry_picker f49bce0 v3-3-test

This should apply the commit to the v3-3-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-3-test Backport to v3-3-test closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants