Optimize CI disk cleanup - #73184
Optimize CI disk cleanup#73184
Conversation
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-3-test
490f63a to
517d2a4
Compare
potiuk
added
the
closed because of open PR limit
|
Hello @zozo123 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 6 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
The script runs on the hot path of most CI jobs. Since apache#45322 a failed deletion or apt cache cleanup only meant less space was freed; with `set -euo pipefail` the same failure would fail the whole job, and the initial `df -H` too. The bounded parallel deletion does not need it, so the script keeps the best-effort behaviour and the test guards it: one failing target must not stop the remaining targets or `apt-get clean`. The test moves to `scripts/tests/tools/` to mirror the script path, and no longer asserts on the script's source text. Generated-by: Claude Fable 5.1
517d2a4 to
1c7703d
Compare
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
3 participants
Delete the existing nine runner-cleanup directories with at most four concurrent processes, then clean the apt cache after all deletions finish. Failed deletions or apt cleanup fail the script.
The production change is confined to
scripts/tools/free_up_disk_space.sh. Cleanup targets are unchanged. Mount ownership and Docker relocation are unchanged from main.Validation: three focused tests pass, exercising the cleanup targets, completion before apt cleanup, and deletion/apt failure propagation. Destructive commands are mocked. Ruff, scripts mypy, applicable manual checks, and ShellCheck pass. Runner-level performance has not been measured; no numerical speedup is claimed.
Split from #73124.
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-6) following the guidelines