Fix Firefox and WebKit UI e2e runs failing at login - #73872
Merged
Merged
Conversation
The e2e global setup always logged in with the first configured Playwright project (Chromium), even when a run was narrowed to Firefox or WebKit. Only the selected browser is installed for such runs, both by breeze and, since the UI dependency caching change, by the CI workflow, so the setup could not launch Chromium and every test failed on a missing auth state file. Generated-by: Claude Opus 5
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl and
vatsrahul1001
as code owners
September 28, 2026 22:46
boring-cyborg
Bot
added
area:dev-tools
area:UI
Generated-by: Claude Opus 5
eladkal
approved these changes
Sep 29, 2026
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
potiuk
added a commit
that referenced
this pull request
Sep 29, 2026
…) (#73879) * Fix Firefox and WebKit UI e2e runs failing at login The e2e global setup always logged in with the first configured Playwright project (Chromium), even when a run was narrowed to Firefox or WebKit. Only the selected browser is installed for such runs, both by breeze and, since the UI dependency caching change, by the CI workflow, so the setup could not launch Chromium and every test failed on a missing auth state file. Generated-by: Claude Opus 5 * Guard against a Playwright config without projects in e2e setup (cherry picked from commit 3f60fa9) Generated-by: Claude Opus 5 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e global setup logs in with
config.projects[0]— always the Chromium project — even when the run is narrowed with--project firefox/--project webkit(config.projectslists every project regardless of--project). Only the selected browser is installed for those runs: bybreeze testing ui-e2e-tests --browser <name>, and, since #73183, by the CI workflow too. So the Firefox and WebKit jobs fail atbrowserType.launchwith a missingchrome-headless-shell, and every test then fails on the missing.auth/user.json(seen e.g. on #73852).Breeze now exports the selected browser as
TEST_BROWSER, and global setup logs in with the matching project, falling back to the first project for--browser alland non-breeze runs.Checked locally: ESLint and Prettier are clean on
global-setup.ts, and ruff is clean on the breeze change.tsc -p tsconfig.dev.jsonreports no new errors (the 3 inglobal-setup.tswere there before). The command has no unit tests; this PR's own Firefox/WebKit e2e jobs are the verification.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines
🤖 Generated with Claude Code