Skip to content

fix: transform each filter key in a dotted relation separately - #143

Merged
pbrassel merged 1 commit into
mainfrom
141-build_filter_params-mangles-dotted-relation-filter-keys
Oct 16, 2026
Merged

pbrassel merged 1 commit into
mainfrom
141-build_filter_params-mangles-dotted-relation-filter-keys

Conversation

@pbrassel

@pbrassel pbrassel commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Filter properties with dotted paths now preserve the path structure and correctly convert each segment to camel case. For example, analysis.client_id produces filter[analysis.clientId].

@pbrassel pbrassel linked an issue Oct 16, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e5087493-ba98-4e1c-b957-c1e16d7df0a6
📥 Commits

Reviewing files that changed from the base of the PR and between f34d536 and 61b93b2.

📒 Files selected for processing: 2
  • flame_hub/_base_client.py
  • tests/test_base_client.py
+----------------------+
| 🧯 Bug extinguished. |
+----------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pbrassel
pbrassel merged commit 1314660 into main Oct 16, 2026
7 of 8 checks passed
@pbrassel
pbrassel deleted the 141-build_filter_params-mangles-dotted-relation-filter-keys branch October 16, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build_filter_params mangles dotted relation filter keys

1 participant