Skip to content

fix: transform each filter key in a dotted relation separately #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbrassel merged 1 commit into from
Oct 16, 2026
Merged

fix: transform each filter key in a dotted relation separately #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion flame_hub/_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,8 @@ def build_filter_params(filter_params: FilterParams | None = None) -> dict:
query_params = {}

for property_name, property_filter in filter_params.items():
query_param_name = f"filter[{to_camel(property_name)}]"
property_name = ".".join(to_camel(p) for p in property_name.split("."))
query_param_name = f"filter[{property_name}]"

if not isinstance(property_filter, tuple): # t.Any -> (FilterOperator, t.Any)
property_filter = (FilterOperator.eq, property_filter)
Expand Down
2 changes: 2 additions & 0 deletions tests/test_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ def test_build_page_params(page_params, expected):
({"id": (">=", "20")}, {"filter[id]": ">=20"}),
({"display_name": ("=", "foo")}, {"filter[displayName]": "foo"}),
({"displayName": ("=", "bar")}, {"filter[displayName]": "bar"}),
({"analysis.client_id": "foo"}, {"filter[analysis.clientId]": "foo"}),
({"analysis.clientId": "bar"}, {"filter[analysis.clientId]": "bar"}),
],
)
def test_build_filter_params(filter_params, expected):
Expand Down
Loading