Repository navigation
test(fuzz): count reopens in copy bases when tracking comment shrink - #1222
Merged
Merged
Conversation
A copy's base operation can reopen the top-level writer. execute() only updated comment_len_at_reopen for top-level reopens, so shrinking the comment after such a reopen left junk before the first local header while the harness still required streaming reads to succeed.
Pr0methean
changed the title
Pr0methean
approved these changes
Oct 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a fuzz harness false positive found in #1210 (run 40805120389,
fuzz_write_with_no_features); reproduces on master.FuzzTestCase::executeonly updatedcomment_len_at_reopenfor top-level reopens. A copy's base can reopen the same writer, so a comment shrink after such a reopen padded junk before the first local header whilestreamablestayed true, andread_zipfile_from_streamfailed withInvalid local file header. Now looks throughShallowCopy/DeepCopybases (not merge sub-writers) when deciding whether an op reopens.Adds
fuzz/write/regressions/nested-copy-comment-shrink-junk.binand a README entry.replay.shoverin+regressions(1011 inputs) passes; fmt and clippy clean.Need help on this PR? Tag
@codesmith-botwith what you need.