Repository navigation
docs(knowledge): approve reconciled zsh-lint parser guidance (#803) - #805
Conversation
Pin the z-shell/zsh-lint parser front-end delivery record to the source merged in f7ec572 (blob dd23834), tested project revision f1c43fa, the consumer blob currently at that revision (59c28b6) and the digest of the complete rendered consumer. The Go AST and wiki records are unchanged. Rendering with the tested revision makes the contract link local to the consumer. Applying the record to an export of f1c43fa changes only .github/instructions/parser-front-end.instructions.md, and check passes. Refs #803
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: maintainer elected after the Copilot request did not register, on 4e9d705
Findings
No actionable findings in the one-file diff against main f7ec572 (merge base equal to base).
Note
This is an author-side review of record, not independent human approval. Adopting the record in zsh-lint PR 699, merging that PR and any release remain separate decisions.
Checklist verdicts
- Scope: pass. Only the z-shell/zsh-lint parser front-end record changes, in five fields; its repository, source, target and the Go AST and wiki records are byte-identical. JSON formatting is unchanged.
- Provenance: pass.
revisionis the #804 merge commit, an ancestor of this head;source_blobdd238342996c67a36610d9fcf89b81645b225474 is that commit's regular-file blob of the source.project_revisionf1c43fac9c8eadfc914a4af89a1beea11afca891 is the revision the source was reconciled against in #804, andproject_source_blob59c28b6a2d0171de0187b04a9dce6de29fe37e8e is the consumer blob at that revision.verify-approvedpasses on this head, covering ancestry, blob identity, rendered digest and selector. - Delivery compatibility: pass. Applying the record to an export of zsh-lint f1c43fac reports AGENTS.md current and rewrites only
.github/instructions/parser-front-end.instructions.md; the result's SHA-256 equalscontent_sha256, andcheckpasses. Five lines change against the current consumer: the provenance comment, the namespace-neutral ownership and import-prefix sentences with the ADR-0041 link, and the two ADR links now pinned at f7ec572. The contract link stays consumer-relative. Markdownlint 0.49.1 with the project configuration reports no findings. - Verification: pass. Knowledge delivery, coverage, agent policy and routing validation pass locally with 339 unit tests, and
git diff --checkand Trunk pass on the manifest. All 11 hosted checks pass on this head, including Org Routing and Agent Instruction Validation; the commit signature is verified.
Limits and follow-up
f1c43fac is the head of unmerged zsh-lint PR 699; the record names it as the tested revision, and a later squash merge will not make it part of zsh-lint's main history. The tooling index's pre-existing sentence about no active project delivery records is outside this change. Native runtime discovery of the regenerated consumer is checked after adoption in the project. Review threads and comments were checked before publication; there are none.
Summary
knowledge/project-delivery.json: revisionf7ec572de9874ebd815fc4e49ce1419084348728(docs(knowledge): reconcile zsh-lint parser guidance with f1c43fa (#803) #804), source blobdd238342996c67a36610d9fcf89b81645b225474, tested project revisionf1c43fac9c8eadfc914a4af89a1beea11afca891(zsh-lint PR 699), the consumer blob currently at that revision59c28b6a2d0171de0187b04a9dce6de29fe37e8e, and content digest75b347cd57824b0b99e9f9da62f61f501e328eb0d32da909d405d4b9aff9532f..github/instructions/parser-front-end.instructions.md.Closes #803
Impact review
knowledge-delivery.py --checkpasses for 57 organization consumers; the rendered project consumer differs in 5 lines from the one at the tested revision.Verification
org-routing.py validateandorg-routing.py verify-approved(with the agent-skills source root) pass, so the revision is an ancestor of this head and the source blob, rendered digest and selector match.f1c43facreportsAGENTS.md is currentand updates only.github/instructions/parser-front-end.instructions.md, whose SHA-256 equals the recorded digest;org-routing.py checkthen passes. The contract link renders as../../docs/project/parser-gap-workflow.md, the ADR links as immutable links atf7ec572d, and the provenance comment carries the new fields.knowledge-delivery.py --check,knowledge-coverage.pyandvalidate-agent-policy.pypass. 339 unit tests pass: knowledge coverage 7, delivery 14, decision records 17, agent policy 99, routing and policy report 91, Zsh standard policy 111.git diff --checkandtrunk check --no-fix --cion the manifest pass.Agent handoff
.github/workflows/org-routing.ymlto the merge commit, then needs fresh checks and a current-head review.