Repository navigation
docs(knowledge): reconcile zsh-lint parser guidance with f1c43fa (#803) - #804
Conversation
Point the parser front-end source's reconciled project revision and contract link at tested zsh-lint commit f1c43fa, which packages the parser fork inside the root module, and link ADR-0041 where the import prefix is explained. Every path, command and symbol the source names exists at that commit; rules, selectors and frontmatter are unchanged. Update the tooling index sentence that names each source's project revision. Prettier pads that page's task table, which the touched file must satisfy. Refs #803
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: maintainer elected after the Copilot request did not register, on 149c199
Findings
No actionable findings in the two-file diff against main 2ddeb0e (merge base equal to base).
Note
This is an author-side review of record, not independent human approval. It does not approve the project delivery record update or the zsh-lint consumer refresh, which follow separately under #803.
Checklist verdicts
- Scope: pass. The parser front-end source changes only its reconciled project revision, its contract link and one added ADR-0041 link. Frontmatter, the
applyToselector, rules, paths and examples are byte-identical. The tooling index changes one sentence; its other lines differ only by Prettier table padding, with identical cell text after whitespace normalization. - Accuracy against the tested project: pass. At zsh-lint f1c43fac9c8eadfc914a4af89a1beea11afca891, every path and symbol the source names exists, including
adapterChain,parseWithAdaptersandparseTreeininternal/parse/adapter_chain.go, theFilemetadata methods, the fork'sRepeatClause,internal/manualcite,cmd/zsh-lint-survey, both fixture directories andthird_party/mvdan-sh/FORK.md. The contract link target exists at that commit (blob 983560749db7aa4004d168095fca09c818bf0b37), and the #287 placement note is still in its section 3. The fork's import prefix and FORK.md packaging text match ADR-0041. - Delivery compatibility: pass. A render with
project_revisionset to f1c43fac rewrites the contract link to../../docs/project/parser-gap-workflow.md, which resolves from the consumer path, and the ADR links become immutable organization revision links. The approved record is unchanged, so no consumer regenerates andverify-approvedstill passes against revision 2169318. - Links and accessibility: pass. The new relative link resolves from
knowledge/domains/tooling/todecisions/0041-zsh-lint-parser-root-module-packaging.md; the link text names the decision, matching the existing ADR links. The links check passes. - Verification: pass. Knowledge delivery, coverage, agent policy, routing validation and approved-revision verification pass locally, with 339 unit tests.
git diff --checkand Trunk pass on both files. All 12 hosted checks pass on this head, and the commit signature is verified.
Limits and follow-up
The index paragraph's last sentence, saying no project delivery record is active for these sources, has been inaccurate since PR 721; it predates this change and is disclosed in the PR body for the follow-up. The Go AST source stays reconciled against 7ff05091 by design. Runtime discovery of the regenerated consumer is not exercised here. Review threads and comments were checked before publication; there are none.
Summary
knowledge/domains/tooling/zsh-lint-parser-front-end.mdagainst tested zsh-lint commitf1c43fac9c8eadfc914a4af89a1beea11afca891(zsh-lint PR 699): the reconciled project revision and the contract link now name that commit, and the import-prefix sentence links ADR-0041. Frontmatter, selectors, rules, paths and examples are unchanged.knowledge/domains/tooling/index.mdthat names each source's project revision: Go AST stays at7ff05091, parser front end moves tof1c43fac. The rest of that file's diff is Prettier padding of its existing task table, which was unformatted on main and is required once the file is touched; no cell text changed.knowledge/project-delivery.jsonstill pins21693189and is updated in the follow-up change.Refs #803
Impact review
.github/instructions/parser-front-end.instructions.md, through the approved project delivery record; the change-impact report selects only z-shell/zsh-lint. The tooling index is organization navigation with no generated consumer.knowledge-delivery.py --checkpasses for 57 consumers; no generated file changes.Verification
f1c43fac, includingadapterChain,parseWithAdaptersandparseTreeininternal/parse/adapter_chain.go, theFilemetadata methods, the fork'sRepeatClause,internal/manualcite,cmd/zsh-lint-survey, the fixture directories andthird_party/mvdan-sh/FORK.md. The Bump crowdin/github-action from 2.0.0 to 2.1.1 #287 placement note is still in section 3 of the contract.project_revisionset tof1c43facrewrites the contract link to../../docs/project/parser-gap-workflow.md, which resolves from the consumer path in that tree; organization links become immutable revision links.knowledge-delivery.py --check,knowledge-coverage.py,validate-agent-policy.py,org-routing.py validateandorg-routing.py verify-approved(with the agent-skills source root) pass.verify-approvedchecks the unchanged approved record, not the new source revision.git diff --checkandtrunk check --no-fix --cion both files pass.Agent handoff
knowledge/project-delivery.jsonto the merged revision and blob, project revisionf1c43fac, the current consumer blob and the rendered digest; that change completes [docs]: reconcile zsh-lint parser guidance for installable packaging #803. zsh-lint PR 699 then regenerates its consumer and repins Org Routing.