Skip to content

Use cached plugin and theme installs in tests - #270

Merged
schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs
Nov 2, 2026
Merged

schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs

Conversation

@schlessera

@schlessera schlessera commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Switches the feature files to the these installed plugins: / these installed themes: steps from wp-cli/wp-cli-tests#404, and requires wp-cli/wp-cli-tests ^5.4.0.

Measured on this test suite: Behat time -4.4% (239.4 → 228.7 job minutes, summed over the matrix). Details in wp-cli/wp-cli-tests#404.

Summary by CodeRabbit

  • Tests
    • Updated media test scenarios to use a theme that is already installed and active, rather than installing it during setup.
  • Chores
    • Updated a development testing tool requirement. These changes affect test setup and development tooling; no end-user-facing changes are included.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 77948640-695a-492e-b15d-502234dea497
Commits

Reviewing files that changed from the base of the PR and between 8dec1aa and c224674.

Files selected for processing: 4
  • composer.json
  • features/media-image-size.feature
  • features/media-prune.feature
  • features/media-regenerate.feature

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The development test dependency constraint changes from ^5 to ^5.4.0. Media feature tests declare twentynineteen installed and active in fixture setup instead of installing and activating it with a command.

Changes: Media test setup

Layer / File(s) Summary
Test dependency and theme fixtures
composer.json, features/media-image-size.feature, features/media-prune.feature, features/media-regenerate.feature
The wp-cli/wp-cli-tests development dependency constraint changes from ^5 to ^5.4.0. The media feature tests declare twentynineteen installed and active in fixture setup.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: swissspidy

Merge Risk: Minimal · up to c2246

The PR updates test dependencies and media fixtures without evidenced merge-blocking impact.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: using cached plugin and theme installs in tests.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added scope:testing Related to testing status:unconfirmed Issue was could not be confirmed yet upstream-bug labels Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schlessera
schlessera force-pushed the measure/cached-extension-installs branch from 4f6d5ad to c224674 Compare November 2, 2026 02:57
@schlessera schlessera changed the title [DO NOT MERGE] Test wp-cli/wp-cli-tests#404 Use cached plugin and theme installs in tests Nov 2, 2026
@schlessera
schlessera marked this pull request as ready for review November 2, 2026 02:57
@schlessera
schlessera requested a review from a team as a code owner November 2, 2026 02:57
@schlessera
schlessera merged commit e2d5576 into main Nov 2, 2026
52 checks passed
@schlessera
schlessera deleted the measure/cached-extension-installs branch November 2, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing status:unconfirmed Issue was could not be confirmed yet upstream-bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant