Repository navigation
Mark the scenarios that need Ghostscript - #273
Conversation
Imagick renders PDF previews through Ghostscript, so these seven scenarios fail where it isn't installed. Tagging them lets the test run skip them there, and lets the shared workflow install Ghostscript only for packages that need it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Ghostscript requirements for PDF scenarios features/media-regenerate.feature |
Seven PDF-related scenarios add a requirement for the Ghostscript binary. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related PRs
- wp-cli/media-command#270: Updates the
wp-cli-testsdevelopment dependency constraint to a version that supports the@require-bin-gstag.
Suggested reviewers: swissspidy
Merge Risk: 
5e1e7
-
This localized change is mergeable with normal checks.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: adding markers to scenarios that require Ghostscript. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
github-actions
Bot
added
automated-pr
command:media
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Imagick renders PDF previews through Ghostscript. These seven scenarios fail where Ghostscript isn't installed, so they now carry
@require-bin-gs, which wp-cli-tests 5.4.0 already supports. Wheregsis missing, the test run skips them instead of failing.This prepares wp-cli/.github to install Ghostscript only for packages with such scenarios. The GitHub runner images no longer ship it, so every Linux Behat job in every package currently spends 15–30 s installing it. media-command is the only package whose tests need it.
How the tagged scenarios were chosen
I ran the full matrix without Ghostscript against that
.githubbranch (run). Exactly these seven scenarios failed on every leg.Regenerating PDFs when thumbnails disabled…passes without Ghostscript, so it stays untagged. With the tags in place (run), all Linux and Windows legs pass.Notes
gswin64c, notgs, so these scenarios are skipped there.mainevery night with these same seven scenarios, even though Ghostscript is installed there. This PR doesn't change that.🤖 Generated with Claude Code
Summary by CodeRabbit