Skip to content

fix(format-rust): use null-delimited git ls-files to prevent quote decoding errors #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LunaStev merged 1 commit into from
Oct 12, 2026
Merged

fix(format-rust): use null-delimited git ls-files to prevent quote decoding errors #921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tools/format-rust.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,17 @@

def rust_files():
result = subprocess.run(
["git", "ls-files", "*.rs"],
["git", "ls-files", "-z", "*.rs"],
cwd=ROOT,
check=True,
capture_output=True,
text=True,
)

for name in result.stdout.splitlines():
for entry in result.stdout.split(b"\x00"):
if not entry:
continue;

name = entry.decode("utf-8")
path = ROOT / name

if any(part in SKIP_DIRS for part in path.parts):
Expand Down
Loading