Repository navigation
fix(format-rust): use null-delimited git ls-files to prevent quote decoding errors - #921
Merged
Merged
Conversation
…coding errors Signed-off-by: tecnolgd <tecnolgd@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an issue in
tools/format-rust.pywhere line-delimitedgit ls-filesparsing dropped or failed on file paths containing spaces or non-ASCII (Unicode) characters. Switched to null-delimited processing (-z) to parse file paths safely.Motivation
Non-ASCII and space-separated file names caused git to wrap paths in double quotes in standard line-delimited outputs, resulting in parsing failures and silent omissions. This update aligns the utility script with robust null-delimited path handling.
Closes #892
Target and compatibility impact
Python tooling script(
tools/format-rust.py) only. No changes to compiler targets, ABIs, or language contracts.Validation
Python compile Check:
python3 -m py_compile tools/format-rust.pyCorpus Verification:
python3 tools/check_wave_corpus.pyManual testing: Created local test files containing spaces and non-ASCII Unicode characters (e.g.,
café.rs,café with spaces.rs).Verified that the original line-delimited
.splitlines()implementation silently dropped these entries (discovering 206 files), whereas the new null-delimited-zimplementation correctly identifies and processes all 208 files without truncation or quoting corruption.Checklist
Signed-off-byline.std/.