Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,13 @@ Some codes raise a subclass of `DockError`, so you can catch them directly:
`ConnectorNotConnectedError` (`connector_not_connected`, 409),
`ConnectorAdminOnlyError` (`connector_admin_only`, 403),
`ConnectorNotFoundError` (`connector_not_found`, 404), `ImageUnknownError`
(`image_unknown`, 400) and `ImageUnavailableError` (`image_unavailable`, 400).
(`image_unknown`, 400), `ImageUnavailableError` (`image_unavailable`, 400),
`PortNotFoundError` (`port_not_found`, 404), `PortLimitReachedError`
(`port_limit_reached`, 409) and `PortsUnavailableError` (`ports_unavailable`,
503).

Port 2222 is reserved for the dock agent and is rejected with
`validation_error`. A dock can expose at most 10 ports.

## Configuration

Expand Down
6 changes: 6 additions & 0 deletions src/usedock/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
DockError,
ImageUnavailableError,
ImageUnknownError,
PortLimitReachedError,
PortNotFoundError,
PortsUnavailableError,
)
from .models import (
Connector,
Expand Down Expand Up @@ -36,4 +39,7 @@
"ImageUnknownError",
"Operation",
"Port",
"PortLimitReachedError",
"PortNotFoundError",
"PortsUnavailableError",
]
15 changes: 15 additions & 0 deletions src/usedock/errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,27 @@ class ImageUnavailableError(DockError):
"""``image_unavailable`` (400): the image is in the catalog but no host serves it right now."""


class PortNotFoundError(DockError):
"""``port_not_found`` (404): closing a port that is not exposed."""


class PortLimitReachedError(DockError):
"""``port_limit_reached`` (409): a dock already exposes the maximum of 10 ports."""


class PortsUnavailableError(DockError):
"""``ports_unavailable`` (503): hosted ports are not configured on this deployment."""


_BY_CODE: Dict[str, Type[DockError]] = {
"connector_not_connected": ConnectorNotConnectedError,
"connector_admin_only": ConnectorAdminOnlyError,
"connector_not_found": ConnectorNotFoundError,
"image_unknown": ImageUnknownError,
"image_unavailable": ImageUnavailableError,
"port_not_found": PortNotFoundError,
"port_limit_reached": PortLimitReachedError,
"ports_unavailable": PortsUnavailableError,
}


Expand Down
6 changes: 6 additions & 0 deletions tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
DockState,
ImageUnavailableError,
ImageUnknownError,
PortLimitReachedError,
PortNotFoundError,
PortsUnavailableError,
)
from usedock.client import MAX_COMMAND_BYTES, shell_quote

Expand Down Expand Up @@ -642,6 +645,9 @@ def test_images_list() -> None:
("connector_admin_only", 403, ConnectorAdminOnlyError),
("image_unknown", 400, ImageUnknownError),
("image_unavailable", 400, ImageUnavailableError),
("port_not_found", 404, PortNotFoundError),
("port_limit_reached", 409, PortLimitReachedError),
("ports_unavailable", 503, PortsUnavailableError),
],
)
def test_new_error_codes_raise_typed_errors(code: str, status: int, cls: type) -> None:
Expand Down
Loading