Repository navigation
feat: ports with visibility - #23
Merged
Merged
Conversation
Add ports list, expose (with public or private visibility) and remove, with tests against the fake server and a README section. Fixes #22 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Review: feat: ports with visibilityVerdict: SHIP Verified against usedock/dock main (3b94716): BlockingNone. Non-blocking
Checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
What
Adds ports to the Python SDK: list, expose with
visibility(publicorprivate, private by default for a new port) and remove. The port type carriesport,visibility,urlandcreatedAt; unknown fields are tolerated. README section added.Why
usedock/dock#92 added port visibility to
POST /v1/docks/:id/portsand the port objects, and this SDK had no ports support. Exposing an already exposed port with a different visibility changes it; leaving it out keeps the current one. No ports scenario exists in sdk-scenarios, so scenarios are untouched.How to verify
ruff check . && ruff format --check . && mypy && DOCK_SCENARIOS_DIR=<dock>/sdk-scenarios pytest -rsResult: all pass, 103 passed and 9 skipped (live-API and CI-only).
Risk
Low. Additive API only; no existing method changes.
🤖 Generated with Claude Code