Skip to content

🐛 Fix critical property assignment for CROCOSuperconductingTFCoil #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-ashe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Fix critical property assignment for CROCOSuperconductingTFCoil #4645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions process/models/tfcoil/superconducting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4031,9 +4031,12 @@ def run(self, output: bool = False):
d_sc_tf.temp_tf_superconductor_critical_zero_field_strain = (
superconductor_critical_properties.tc0m
)
d_sc_tf.cur_tf_turn_croco_strand_critical = d_sc_tf.c_tf_turn_cables_critical = (
d_sc_tf.c_tf_turn_cables_critical = (
superconductor_critical_properties.c_turn_cables_critical
)
d_sc_tf.cur_tf_turn_croco_strand_critical = (
d_sc_tf.c_tf_turn_cables_critical / N_CROCO_STRANDS_TURN
)
Comment on lines +4037 to +4039

@kj5248 kj5248 Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calculation is right however I have concerns over circular nature of calculation with other places in the file. I'll flag them.


if self.data.tfcoil.i_str_wp == 0:
strain = self.data.tfcoil.str_tf_con_res
Expand Down Expand Up @@ -4585,7 +4588,7 @@ def tf_croco_superconductor_properties(
j_tf_coil_turn=j_tf_coil_turn,
bc20m=bc20m,
tc0m=tc0m,
c_turn_cables_critical=cur_tf_turn_croco_strand_critical,
c_turn_cables_critical=cur_tf_turn_critical,
)

@staticmethod
Expand Down
Loading