Skip to content

🐛 Fix critical property assignment for CROCOSuperconductingTFCoil - #4645

Open
chris-ashe wants to merge 1 commit into
mainfrom
croco_critical_bug
Open

chris-ashe wants to merge 1 commit into
mainfrom
croco_critical_bug

Conversation

@chris-ashe

@chris-ashe chris-ashe commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

This pull request refactors how the critical current values for TF coil turn cables and CROCO strands are calculated and passed within the superconducting model. The main focus is to ensure that the critical current for the entire turn cable is separated from that of individual CROCO strands, improving clarity and correctness in the data flow.

Refactoring of critical current calculations:

  • In superconducting.py, the assignment of c_tf_turn_cables_critical and cur_tf_turn_croco_strand_critical is separated, with the strand critical current now explicitly calculated as the turn cable critical current divided by N_CROCO_STRANDS_TURN.
  • In the tf_croco_superconductor_properties function, the value passed for c_turn_cables_critical is changed from the strand critical current to the overall turn critical current, ensuring the correct value is used in downstream calculations.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe
chris-ashe requested a review from a team as a code owner October 2, 2026 17:03
@chris-ashe chris-ashe added TF Coil Toroidal field coil Bug Something isnt working labels Oct 2, 2026
@chris-ashe chris-ashe changed the title Fix critical property assignment for CROCOSuperconductingTFCoil 🐛 Fix critical property assignment for CROCOSuperconductingTFCoil Oct 2, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.97%. Comparing base (c7056b0) to head (84db504).

Files with missing lines Patch % Lines
process/models/tfcoil/superconducting.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4645      +/-   ##
==========================================
- Coverage   49.97%   49.97%   -0.01%     
==========================================
  Files         151      151              
  Lines       30270    30271       +1     
==========================================
  Hits        15128    15128              
- Misses      15142    15143       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isnt working TF Coil Toroidal field coil

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants