Repository navigation
Let the shared cache of the core keep the pages that show the highlights - #23
Merged
Merged
Conversation
anoziere
force-pushed
the
feat/shared-cache
branch
from
October 21, 2026 08:07
0696012 to
0b37324
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declares
/api/header-highlightsto the shared cache of the public pages added by thelia/thelia#4148. A page that reads the highlights can now be kept by the proxy, taggedheader_highlights, and saving or deleting a highlight or its image purges that key.SharedCache/HeaderHighlightsSharedCacheimplementsThelia\Core\SharedCache\SharedCacheContributorInterface.SharedCache/HeaderHighlightsPurgeListenerpurges on the Propel post save and post delete events of the four tables, which every write of the configuration screen goes through.Tests/Integration, run from the shop root afterphp bin/test-preparewithvendor/bin/phpunit -c local/modules/HeaderHighlights.Needs the release of
thelia/corethat contains thelia/thelia#4148 (SharedCacheContributorInterfaceandSharedCacheInvalidatorare not in 3.2.3): merge after it.Seen while testing, not changed here: the configuration screen cannot save a block that has no image yet (the insert into
header_highlights_imagefails on the requiredfilecolumn), and a highlight saved without a call to action breaks every front page (nulltextgiven to the button component).