Repository navigation
fix: optional highlight fields, blocks without image or call to action - #25
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes over #16 by @pierrebaguet, rebased on the Thelia 3 code: its two commits are kept as they are (category and fields optional, "Choose a category" entry).
Making those fields optional exposed two failures, fixed here:
filecolumn is required. The image is now attached only when a file is uploaded, so no empty image row is written. No schema change.Also: the image model is declared with a consistent constructor, which clears the only PHPStan error of the module.
Version 2.1.3. #23 (shared cache) is untouched and still waits for the next core release.