Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 20, 2026
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 20, 2026 09:48
2072bd1 to
9365aa1
Compare
ctrlc03
force-pushed
the
large/param-sets-reindex
branch
from
November 20, 2026 09:48
be547b3 to
92e7a2c
Compare
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 20, 2026 17:21
9365aa1 to
f205b56
Compare
ctrlc03
force-pushed
the
large/param-sets-reindex
branch
from
November 20, 2026 17:21
92e7a2c to
32ae899
Compare
- Registration is append-only and live registries hold earlier tuples at indices 0, 1 and 2, so the 45-party tuples cannot take indices 0 and 2 in place. - ON_CHAIN_PARAMETER_SETS maps index 3 to secure-8192 and index 4 to insecure-64. BfvProtocol.sol and crypto-config.json are regenerated. - The indexer resolves indices 3 and 4 only through a current profile identity. It reads indices 0, 1 and 2 from the registry bytes under their frozen threshold-only ID: v5 at indices 0 and 2, v1 at indices 0 and 1. - bfv_protocol.json keeps the v0.19 tuples as historical v5 vectors, computed independently with ethers. - The SDK ParamSet enum, the fake Interfold fixture and the test inputs follow the new indices. BREAKING CHANGE: new requests use parameter set 3 (secure-8192) or 4 (insecure-64). Indices 0, 1 and 2 are historical.
- upgrades.md replaces the unresolved registry-index gap with the cutover procedure: register index 3 (secure) and index 4 (insecure, testnets) in the paused governance batch, check the exact bytes before resume, and keep indices 0, 1 and 2 as historical registry reads. - The developer pages, the committee-selection note and the SDK README name indices 3 and 4.
…er batch - `upgrade:v19 prepare` registered only the secure index 3, and `validate` checked only that index. Sepolia requests default to the insecure index 4, so a resumed Sepolia would reject them with "BFV param set not registered". - `prepare` now adds one `setParamSet` call for each parameter set of the chain that the registry lacks, and stops if an index holds other bytes. - `validate`, and `resume` through it, check every parameter set of the chain. - The plan records `paramSetsRegisteredByBatch` in place of `paramSet` and `paramSetRegisteredByBatch`. - The cutover test uses index 3 and covers a batch that registers two sets.
…ameter-set branch
…set 3 sync-secure-8192 takes the SS secure threshold preset, so it follows that preset's move to registry index 3, as sync-insecure-64 already follows index 4.
…y the rebase onto main
Pre-cutover E3s at slots 0 and 2 now resolve through the registry bytes rather than a local preset. The fake Interfold gains setParamSet, and a backfill test registers the historical insecure v5 tuple at slot 0: a request under its threshold-only ID is stored with those exact bytes, and a request under another ID at the slot is skipped.
Sepolia index 0 holds the degree-64 v5 tuple of a later redeployment, not the v0.19.x tuple; a fresh Mainnet deployment registers index 3 only; an unregistered historical index fails as not registered before the crypto-config check; clients derive the index from bfvConfiguration in @interfold/contracts/bfv, since the SDK does not export ParamSet; and a rollback leaves indices 3 and 4 registered but inert.
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 21, 2026 15:26
f205b56 to
f177b67
Compare
ctrlc03
force-pushed
the
large/param-sets-reindex
branch
from
November 21, 2026 15:26
32ae899 to
5300997
Compare
Collaborator
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Split from #2398 (Zara's work). Stacked on #2542 (
large/params-n45); review that one first.setParamSetis append-only, and the live registries hold earlier tuples at indices 0, 1 and 2(Mainnet 0, 1, 2; Sepolia 0 and 2). The 45-party tuples from #2542 therefore take new indices, and
the old ones stay readable as history.
from the registry bytes under their frozen threshold-only ID (v5 at 0 and 2, v1 at 0 and 1).
bfv_protocol.jsonkeeps the v0.19 and v1 tuples as historical vectors.ParamSetenum,fake_interfold.soland the contract tests follow the new indices.upgrade:v19 prepareregisters every parameter set the chain lacks (3 on Mainnet; 3 and 4 onSepolia) and stops if an index holds other bytes;
validatechecks them all.docs/architecture/upgrades.mdgives the cutover procedure, and the build docs name the newindices.
Verification
Static checks only; CI runs the tests.
cargo check --all-targetsfor the affected crates (including the indexer tests, with theSolidity fixtures built),
cargo fmt --check,node scripts/blueprint/check.mjs,node scripts/circuits/crypto-config.mjs --check --sources, prettier,tsc --noEmitforinterfold-contracts.paramSetRegistrybytes(read-only
eth_call); indices 3 and 4 are empty on both chains.Compatibility
Breaking within the unreleased protocol-9 cutover (no separate counter change).
getE3Quoteandrequestreject 0, 1 and 2, and nodesskip request events that name them. Clients that hard-code 0 or 2, such as the CRISP server's
E3_PARAM_SET(separate repository), must change with the release.setParamSet(3, …)on Mainnet and Sepolia andsetParamSet(4, …)onSepolia. Before resume, check
keccak256(paramSetRegistry(3))=0x4f402598…08c3andkeccak256(paramSetRegistry(4))=0x2898f8a9…a844.paramSet/paramSetRegisteredByBatchis nowparamSetsRegisteredByBatch: number[].are regenerated in chore(circuits): regenerate the circuit outputs of the large stack #2541 (
large/circuit-outputs), near the top ofthe stack. Until then this PR's circuit, verifier and layout-lock checks fail
by design.
Update 2026-11-21: rebased onto main (#2524–#2530) and Fable review fixes
8479ea19a: sync-secure-8192 follows the SS secure preset to parameter set 3.7892192aa: blueprint refs moved by the rebase.79f015a64: an indexer backfill test reads a historical slot from the registry (stored with the registry bytes under the v5 ID; another ID at that slot is skipped). This is the path the 55 live pre-cutover E3s take.5300997b9: registry facts corrected: Sepolia index 0 is the later degree-64 redeployment, a fresh Mainnet deployment registers index 3 only, an unregistered index fails as not registered, clients usebfvConfiguration(...).paramSetfrom@interfold/contracts/bfv, and a rollback leaves indices 3 and 4 registered but inert.