Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 19, 2026 22:58
6d37d70 to
84d9282
Compare
ctrlc03
force-pushed
the
large/committee-large
branch
from
November 19, 2026 22:58
054e4cb to
e0853dc
Compare
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 19, 2026 23:30
84d9282 to
ff0afea
Compare
ctrlc03
force-pushed
the
large/committee-large
branch
from
November 19, 2026 23:30
e0853dc to
cd591ed
Compare
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 20, 2026 08:50
ff0afea to
9493eaa
Compare
ctrlc03
force-pushed
the
large/committee-large
branch
from
November 20, 2026 08:50
cd591ed to
b7bb171
Compare
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 20, 2026 09:11
9493eaa to
2072bd1
Compare
ctrlc03
force-pushed
the
large/committee-large
branch
from
November 20, 2026 09:11
b7bb171 to
59dd930
Compare
ctrlc03
changed the base branch from
large/params-n45
to
large/param-sets-reindex
November 20, 2026 09:11
ctrlc03
force-pushed
the
large/param-sets-reindex
branch
from
November 20, 2026 09:48
be547b3 to
92e7a2c
Compare
ctrlc03
force-pushed
the
large/committee-large
branch
from
November 20, 2026 09:48
59dd930 to
d51a593
Compare
ctrlc03
force-pushed
the
large/param-sets-reindex
branch
from
November 20, 2026 17:21
92e7a2c to
32ae899
Compare
ctrlc03
force-pushed
the
large/committee-large
branch
from
November 20, 2026 17:21
d51a593 to
4bff392
Compare
Define a fourth committee size beside minimum, micro and small. It is wire variant 3 of CiphernodesCommitteeSize and IInterfold.CommitteeSize, so the published enum values stay. The shared committee owner carries N = 45, H = 34 and T = 22, and the generated Noir, Solidity and TypeScript bindings follow it. - Both SS profiles admit the committee, so each gains a configuration ID (SS_INSECURE_64_LARGE_CONFIG_ID, SS_SECURE_8192_LARGE_CONFIG_ID). ActiveCryptoConfig accepts the size and returns those IDs. - build-pairs.json builds insecure-64/large and secure-8192/large. The release matrix and the chain deployment routes do not change here. - The SDK, the hardhat request task, the circuit and committee checks, the Rust enum consumers and the docs list the fourth size. Breaking: nodes that predate the variant cannot decode a Large request.
Three node proofs per step stay within 2^22 at n = 45 (3.71M gates).
…over its thresholds
The CRISP server rejects E3_COMMITTEE_SIZE above 2 at startup (theinterfold/CRISP server/src/config.rs), so the settings table must not offer 3 for the large committee.
The DKG aggregation shape test and the C1/C2 commitment width test name every canonical committee, and they stopped at small.
The dashboard hard-coded T for Minimum, Micro and Small, so a Large E3 showed 0 of 45 shares required. It now reads COMMITTEES from @interfold/contracts/bfv. The mainnet notes in ActiveCryptoConfig.sol and committee-selection.md say the contract accepts any size whose threshold is set and the configuration keeps mainnet to minimum/micro/small; the circuit-artifacts rewrap no longer splits 'provenance/ publication'.
ctrlc03
force-pushed
the
large/committee-large
branch
from
November 21, 2026 15:26
4bff392 to
f1ea432
Compare
Collaborator
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Split from #2398 (Zara's work). Stacked on #2539 (
large/param-sets-reindex); review that one first.Adds a fourth committee size, Large: N = 45, H = 34, T = 22. It is wire variant 3 of
CiphernodesCommitteeSizeandIInterfold.CommitteeSize, appended after Small, so the publishedvalues keep their meaning.
e3-committeecarries the new variant; both SS profiles admit it, so each gains a configurationID (
SS_INSECURE_64_LARGE_CONFIG_ID,SS_SECURE_8192_LARGE_CONFIG_ID). The generatedcommittee/large/mod.nr,BfvProtocol.solandcrypto-config.jsoncome frompnpm generate:crypto-bindings.ActiveCryptoConfigaccepts the size and returns those IDs;Interfold.MAX_COMMITTEE_SIZErisesfrom 19 to 45 (
ActiveCryptoConfig.LARGE_N).bfv.ts, the harness, the SDKCommitteeSize, thehardhat request task and the EVM enum follow. Nodes decode the new variant through the shared
enum.
scripts/utils.tsresolvesACTIVE_BFV_CONFIGwithbfvConfig(ACTIVE_BFV_PRESET, ACTIVE_BFV_COMMITTEE)instead of a testnet route lookup, so a local Large build works before anyroute exists.
tests/integration/lib/utils.shprobes committee size 3.build-pairs.jsonbuildsinsecure-64/largeandsecure-8192/large. The release matrix, thedeployment routes and the mainnet configuration do not change here.
committee.sh,scripts/circuits/test.sh, the circuit tooling tests and the docs list thefourth size, except the CRISP server settings: the CRISP server (separate repository) still
accepts only 0 to 2. The landing page, network tables and ticket table follow in the next PR.
proof-statements.mdgives the nodes fold step at n = 45 (3.71M gates).supported_committees_fit_the_parameter_search_party_count(crates/bfv/params); thee3-zk-provercommittee-list tests include Large.Verification
Static checks only; CI runs the tests.
nargo checkof the lib,config,dkg,threshold,chonkand every recursive workspacewith the Large committee selected, for both presets (scratch selection, restored).
cargo check --workspace --lib --binsand--all-targetsfor the affected crates (the indexer andevm-client test targets need prebuilt contract fixtures and were not checked),
cargo fmt --check.scripts/circuits/lint.sh,bash scripts/checks/committee.sh,node scripts/circuits/crypto-config.mjs --check --sources(it stages only the activecommittee),
pnpm check:bindings,node scripts/blueprint/check.mjs, prettier,tsc --noEmitfor
interfold-contracts.bfv_profiles.jsongains the two Large entries, recomputed independently with ethers.Compatibility
Breaking within the unreleased protocol-9 cutover (no separate counter change).
routes are unchanged. The deployment routes and tooling do not configure Large until the next PR;
ActiveCryptoConfigalready accepts Large on any chain once the owner sets thresholds[34, 45]for size 3.
PR does not need them; the next PR does.
Largerows. They, the VK catalogue, the Solidity verifiers and theBFV VK-binding fixture are regenerated once, from one matrix build, in chore(circuits): regenerate the circuit outputs of the large stack #2541 (
large/circuit-outputs), near the top ofthe stack. Until then this PR's circuit, verifier and layout-lock checks fail by
design.
Update 2026-11-21: rebased onto main (#2524–#2530) and Fable review fixes
160b02ef6: blueprint refs moved by the rebase.b49911d5e: prettier rewrap of the conflict-resolvedcircuit-artifacts.mdparagraph.f1ea4321e: the dashboard derived T from a hard-coded table and showed a Large E3 as "0 of 45"; it now readsCOMMITTEES. The mainnet notes say the contract accepts any size whose threshold is set; the configuration keeps mainnet to minimum/micro/small.supports_committeenow covers SS × 4 committees and both synchronized profiles on Minimum;profile_identity.rsexpects 10.