Skip to content

feat(committee)!: add the large committee (n = 45, h = 34, t = 22) - #2536

Closed
ctrlc03 wants to merge 14 commits into
large/param-sets-reindexfrom
large/committee-large
Closed

ctrlc03 wants to merge 14 commits into
large/param-sets-reindexfrom
large/committee-large

Conversation

@ctrlc03

@ctrlc03 ctrlc03 commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Split from #2398 (Zara's work). Stacked on #2539 (large/param-sets-reindex); review that one first.

Adds a fourth committee size, Large: N = 45, H = 34, T = 22. It is wire variant 3 of
CiphernodesCommitteeSize and IInterfold.CommitteeSize, appended after Small, so the published
values keep their meaning.

  • e3-committee carries the new variant; both SS profiles admit it, so each gains a configuration
    ID (SS_INSECURE_64_LARGE_CONFIG_ID, SS_SECURE_8192_LARGE_CONFIG_ID). The generated
    committee/large/mod.nr, BfvProtocol.sol and crypto-config.json come from
    pnpm generate:crypto-bindings.
  • ActiveCryptoConfig accepts the size and returns those IDs; Interfold.MAX_COMMITTEE_SIZE rises
    from 19 to 45 (ActiveCryptoConfig.LARGE_N). bfv.ts, the harness, the SDK CommitteeSize, the
    hardhat request task and the EVM enum follow. Nodes decode the new variant through the shared
    enum.
  • scripts/utils.ts resolves ACTIVE_BFV_CONFIG with bfvConfig(ACTIVE_BFV_PRESET, ACTIVE_BFV_COMMITTEE) instead of a testnet route lookup, so a local Large build works before any
    route exists. tests/integration/lib/utils.sh probes committee size 3.
  • build-pairs.json builds insecure-64/large and secure-8192/large. The release matrix, the
    deployment routes and the mainnet configuration do not change here.
  • committee.sh, scripts/circuits/test.sh, the circuit tooling tests and the docs list the
    fourth size, except the CRISP server settings: the CRISP server (separate repository) still
    accepts only 0 to 2. The landing page, network tables and ticket table follow in the next PR.
    proof-statements.md gives the nodes fold step at n = 45 (3.71M gates).
  • New test supported_committees_fit_the_parameter_search_party_count (crates/bfv/params); the
    e3-zk-prover committee-list tests include Large.

Verification

Static checks only; CI runs the tests.

  • nargo check of the lib, config, dkg, threshold, chonk and every recursive workspace
    with the Large committee selected, for both presets (scratch selection, restored).
  • cargo check --workspace --lib --bins and --all-targets for the affected crates (the indexer and
    evm-client test targets need prebuilt contract fixtures and were not checked), cargo fmt --check.
  • scripts/circuits/lint.sh, bash scripts/checks/committee.sh,
    node scripts/circuits/crypto-config.mjs --check --sources (it stages only the active
    committee), pnpm check:bindings, node scripts/blueprint/check.mjs, prettier, tsc --noEmit
    for interfold-contracts.
  • bfv_profiles.json gains the two Large entries, recomputed independently with ethers.

Compatibility

Breaking within the unreleased protocol-9 cutover (no separate counter change).

  • Nodes that predate the variant cannot decode a Large request. Existing committees and mainnet
    routes are unchanged. The deployment routes and tooling do not configure Large until the next PR;
    ActiveCryptoConfig already accepts Large on any chain once the owner sets thresholds [34, 45]
    for size 3.
  • The Large circuits and verifiers are not generated here. CI builds only the default pair, so this
    PR does not need them; the next PR does.
  • The layout-lock fixtures gain Large rows. They, the VK catalogue, the Solidity verifiers and the
    BFV VK-binding fixture are regenerated once, from one matrix build, in chore(circuits): regenerate the circuit outputs of the large stack #2541 (large/circuit-outputs), near the top of
    the stack. Until then this PR's circuit, verifier and layout-lock checks fail by
    design.

Update 2026-11-21: rebased onto main (#2524–#2530) and Fable review fixes

  • 160b02ef6: blueprint refs moved by the rebase.
  • b49911d5e: prettier rewrap of the conflict-resolved circuit-artifacts.md paragraph.
  • f1ea4321e: the dashboard derived T from a hard-coded table and showed a Large E3 as "0 of 45"; it now reads COMMITTEES. The mainnet notes say the contract accepts any size whose threshold is set; the configuration keeps mainnet to minimum/micro/small.
  • Rebase: supports_committee now covers SS × 4 committees and both synchronized profiles on Minimum; profile_identity.rs expects 10.

@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interfold-dashboard Ready Ready Preview Nov 21, 2026 3:27pm UTC
interfold-docs Ready Ready Preview Nov 21, 2026 3:27pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 5300997 and f1ea432.

Files selected for processing: 56

  • circuits/lib/src/configs/committee/active.nr
  • circuits/lib/src/configs/committee/large/mod.nr
  • circuits/lib/src/configs/committee/mod.nr
  • crates/bfv/params/src/profiles.rs
  • crates/bfv/params/tests/fixtures/bfv_profiles.json
  • crates/bfv/params/tests/profile_identity.rs
  • crates/committee/README.md
  • crates/committee/src/lib.rs
  • crates/evm/contracts/src/enums.rs
  • crates/evm/indexer/tests/fixtures/fake_interfold.sol
  • crates/zk/benchmarks/src/circuit_benchmark/protocol.rs
  • crates/zk/build/src/lib.rs
  • crates/zk/build/src/tests.rs
  • crates/zk/build/templates/committee_active.nr.in
  • crates/zk/prover/src/backend/download.rs
  • crates/zk/prover/src/circuits/aggregation/node_dkg_fold.rs
  • crates/zk/prover/src/commitment_links/c1_to_c2.rs
  • docs/architecture/circuit-artifacts.md
  • docs/architecture/committee-selection.md
  • docs/architecture/proof-statements.md
  • docs/pages/build/interfold-contract.mdx
  • docs/pages/build/noir-circuits.mdx
  • docs/pages/build/requesting-an-e3.mdx
  • docs/pages/build/sdk.mdx
  • docs/pages/internals/dkg.mdx
  • docs/pages/internals/sortition.mdx
  • docs/pages/learn/cryptography.mdx
  • docs/pages/learn/what-is-e3.mdx
  • docs/pages/reference/contracts.mdx
  • docs/pages/reference/glossary.mdx
  • packages/interfold-contracts/bfv.ts
  • packages/interfold-contracts/contracts/Interfold.sol
  • packages/interfold-contracts/contracts/interfaces/IInterfold.sol
  • packages/interfold-contracts/contracts/lib/ActiveCryptoConfig.sol
  • packages/interfold-contracts/contracts/lib/BfvProtocol.sol
  • packages/interfold-contracts/contracts/test/BfvProtocolHarness.sol
  • packages/interfold-contracts/crypto-config.json
  • packages/interfold-contracts/scripts/utils.ts
  • packages/interfold-contracts/tasks/interfold.ts
  • packages/interfold-contracts/test/Governance/AccessAndBounds.spec.ts
  • packages/interfold-contracts/test/Pricing/Pricing.spec.ts
  • packages/interfold-dashboard/src/lib/e3.ts
  • packages/interfold-sdk/scripts/compile-circuits.sh
  • packages/interfold-sdk/src/contracts/types.ts
  • packages/interfold-sdk/tests/circuit-selection.test.ts
  • scripts/blueprint/facts/10-contracts.json
  • scripts/blueprint/facts/12-sdk.json
  • scripts/checks/committee.sh
  • scripts/checks/integration-committee.test.ts
  • scripts/circuits/README.md
  • scripts/circuits/bfv-bindings.test.ts
  • scripts/circuits/build-pairs.json
  • scripts/circuits/constants.ts
  • scripts/circuits/test.sh
  • scripts/circuits/verifiers.ts
  • tests/integration/lib/utils.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ctrlc03
ctrlc03 force-pushed the large/committee-large branch from 054e4cb to e0853dc Compare November 19, 2026 22:58
@ctrlc03
ctrlc03 force-pushed the large/committee-large branch from e0853dc to cd591ed Compare November 19, 2026 23:30
@ctrlc03
ctrlc03 force-pushed the large/committee-large branch from cd591ed to b7bb171 Compare November 20, 2026 08:50
@ctrlc03
ctrlc03 added this pull request to stack #2538 November 20, 2026 08:50
@ctrlc03
ctrlc03 removed this pull request from stack #2538 November 20, 2026 09:11
@ctrlc03
ctrlc03 force-pushed the large/committee-large branch from b7bb171 to 59dd930 Compare November 20, 2026 09:11
@ctrlc03
ctrlc03 changed the base branch from large/params-n45 to large/param-sets-reindex November 20, 2026 09:11
@ctrlc03
ctrlc03 added this pull request to stack #2543 November 20, 2026 09:22
@ctrlc03
ctrlc03 force-pushed the large/param-sets-reindex branch from be547b3 to 92e7a2c Compare November 20, 2026 09:48
@ctrlc03
ctrlc03 force-pushed the large/committee-large branch from 59dd930 to d51a593 Compare November 20, 2026 09:48
@ctrlc03
ctrlc03 force-pushed the large/param-sets-reindex branch from 92e7a2c to 32ae899 Compare November 20, 2026 17:21
zahrajavar and others added 14 commits November 21, 2026 14:26
Define a fourth committee size beside minimum, micro and small. It is wire
variant 3 of CiphernodesCommitteeSize and IInterfold.CommitteeSize, so the
published enum values stay. The shared committee owner carries N = 45,
H = 34 and T = 22, and the generated Noir, Solidity and TypeScript bindings
follow it.

- Both SS profiles admit the committee, so each gains a configuration ID
  (SS_INSECURE_64_LARGE_CONFIG_ID, SS_SECURE_8192_LARGE_CONFIG_ID).
  ActiveCryptoConfig accepts the size and returns those IDs.
- build-pairs.json builds insecure-64/large and secure-8192/large. The
  release matrix and the chain deployment routes do not change here.
- The SDK, the hardhat request task, the circuit and committee checks, the
  Rust enum consumers and the docs list the fourth size.

Breaking: nodes that predate the variant cannot decode a Large request.
Three node proofs per step stay within 2^22 at n = 45 (3.71M gates).
The CRISP server rejects E3_COMMITTEE_SIZE above 2 at startup
(theinterfold/CRISP server/src/config.rs), so the settings table must
not offer 3 for the large committee.
The DKG aggregation shape test and the C1/C2 commitment width test
name every canonical committee, and they stopped at small.
The dashboard hard-coded T for Minimum, Micro and Small, so a Large E3 showed 0 of 45 shares required. It now reads COMMITTEES from @interfold/contracts/bfv. The mainnet notes in ActiveCryptoConfig.sol and committee-selection.md say the contract accepts any size whose threshold is set and the configuration keeps mainnet to minimum/micro/small; the circuit-artifacts rewrap no longer splits 'provenance/ publication'.
@ctrlc03

ctrlc03 commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator Author

Folded into #2542 so that each PR in the stack passes CI on its own: main requires template_integration, which cannot pass on a PR that changes circuits without their regenerated outputs. This PR's commits and description are unchanged inside #2542; its review threads stay here.

This branch was successfully deployed

2 active deployments
Preview – interfold-dashboard — f1ea4321 Deployed Nov 21, 2026 by vercel[bot]
Preview – interfold-docs — f1ea4321 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants