Repository navigation
Conversation
lilydoar
force-pushed
the
lilydoar/worker-heartbeat-batching
branch
2 times, most recently
from
October 26, 2026 21:16
333090d to
3c075d8
Compare
THardy98
approved these changes
Oct 27, 2026
lilydoar
force-pushed
the
lilydoar/worker-heartbeat-batching
branch
from
October 27, 2026 20:55
3c075d8 to
8d029b4
Compare
lilydoar
force-pushed
the
lilydoar/worker-heartbeat-batching
branch
from
October 27, 2026 20:58
8d029b4 to
6663510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Expose the Go SDK's maximum heartbeat throttle interval as a worker option. Zero retains SDK defaults, and named worker profiles keep precedence over individual tuning flags.
Review: As a single unit in stack order.
Why
Calling RecordHeartbeat more frequently does not necessarily send RPCs more frequently: the SDK batches them. Controlling that batching interval lets load profiles tune persistence cadence independently of the activity heartbeat timeout and retry policy.
Details worth reviewing
Merge after #519, including the SDK prerequisite inherited through #518. This adds a capability; it does not activate a new batching interval in a shared profile.