Repository navigation
Conversation
lilydoar
force-pushed
the
lilydoar/retry-probe-timing
branch
from
October 26, 2026 21:12
81498c0 to
af11db8
Compare
lilydoar
force-pushed
the
lilydoar/retry-probe-timing
branch
from
October 26, 2026 21:16
af11db8 to
296d082
Compare
lilydoar
force-pushed
the
lilydoar/retry-probe-timing
branch
from
October 27, 2026 20:55
296d082 to
012c75f
Compare
lilydoar
force-pushed
the
lilydoar/retry-probe-timing
branch
from
October 27, 2026 20:58
012c75f to
25d9847
Compare
lilydoar
force-pushed
the
lilydoar/retry-probe-timing
branch
3 times, most recently
from
October 28, 2026 20:06
e276e7a to
03b0f6c
Compare
lilydoar
force-pushed
the
lilydoar/retry-probe-timing
branch
from
October 28, 2026 20:34
03b0f6c to
d68cda3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add
retry-scenario-timeoutto scale the finite retry probes' deadlines and deliberate failure durations together. The existing default and two-attempt contract remain: the first attempt deliberately fails and the second must succeed.Review: As a single unit in stack order.
Why
A fixed one-second success window leaves no way to tune these probes for persistence-fault runs. Increasing only the deadline would make an intentional timeout stop timing out, losing the behavior the pipeline is meant to test.
Details worth reviewing
Merge after #526, including #518's SDK prerequisite. Healthy heartbeat actions retain their separate timing and single-attempt policy. The new option is a tuning capability, not a qualified FI setting.