Skip to content

fix(connectors): use model-safe tool input names #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewstone merged 1 commit into from
Oct 1, 2026
Merged

fix(connectors): use model-safe tool input names #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/bundled-adapter-manifests.json
View file
Open in desktop

Large diffs are not rendered by default.

34 changes: 17 additions & 17 deletions src/connectors/adapters/azure-ad.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,22 +48,22 @@ export const azureAdConnector = declarativeRestConnector({
parameters: {
type: 'object',
properties: {
$filter: { type: 'string' },
$select: { type: 'string' },
$top: { type: 'integer' },
$search: { type: 'string' },
$orderby: { type: 'string' },
filter: { type: 'string' },
select: { type: 'string' },
top: { type: 'integer' },
search: { type: 'string' },
orderBy: { type: 'string' },
},
},
request: {
method: 'GET',
path: '/users',
query: {
$filter: '{$filter}',
$select: '{$select}',
$top: '{$top}',
$search: '{$search}',
$orderby: '{$orderby}',
$filter: '{filter}',
$select: '{select}',
$top: '{top}',
$search: '{search}',
$orderby: '{orderBy}',
},
},
requiredScopes: ['User.ReadWrite.All'],
Expand All @@ -75,17 +75,17 @@ export const azureAdConnector = declarativeRestConnector({
parameters: {
type: 'object',
properties: {
$select: { type: 'string' },
$top: { type: 'integer' },
select: { type: 'string' },
top: { type: 'integer' },
},
},
request: {
method: 'GET',
path: '/users',
query: {
$filter: 'accountEnabled eq true',
$select: '{$select}',
$top: '{$top}',
$select: '{select}',
$top: '{top}',
},
},
requiredScopes: ['User.ReadWrite.All'],
Expand Down Expand Up @@ -287,15 +287,15 @@ export const azureAdConnector = declarativeRestConnector({
type: 'object',
properties: {
id: { type: 'string' },
$select: { type: 'string' },
$top: { type: 'integer' },
select: { type: 'string' },
top: { type: 'integer' },
},
required: ['id'],
},
request: {
method: 'GET',
path: '/groups/{id}/members',
query: { $select: '{$select}', $top: '{$top}' },
query: { $select: '{select}', $top: '{top}' },
},
requiredScopes: ['GroupMember.ReadWrite.All', 'Group.ReadWrite.All'],
},
Expand Down
4 changes: 2 additions & 2 deletions src/connectors/adapters/mailgun.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const mailgunConnector = declarativeRestConnector({
to: { type: 'string', description: 'Comma-separated recipient addresses.' },
cc: { type: 'string' },
bcc: { type: 'string' },
'h:Reply-To': { type: 'string' },
replyTo: { type: 'string', description: 'Reply-To email address.' },
subject: { type: 'string' },
text: { type: 'string' },
html: { type: 'string' },
Expand All @@ -60,7 +60,7 @@ export const mailgunConnector = declarativeRestConnector({
to: '{to}',
cc: '{cc}',
bcc: '{bcc}',
'h:Reply-To': '{h:Reply-To}',
'h:Reply-To': '{replyTo}',
subject: '{subject}',
text: '{text}',
html: '{html}',
Expand Down
24 changes: 12 additions & 12 deletions src/connectors/adapters/microsoft-365-people.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,14 @@ export const microsoft365PeopleConnector = declarativeRestConnector({
type: 'object',
properties: {
contactFolderId: { type: 'string' },
$select: { type: 'string' },
select: { type: 'string' },
},
required: ['contactFolderId'],
},
request: {
method: 'GET',
path: '/me/contactFolders/{contactFolderId}',
query: { $select: '{$select}' },
query: { $select: '{select}' },
},
requiredScopes: ['Contacts.ReadWrite'],
},
Expand All @@ -148,23 +148,23 @@ export const microsoft365PeopleConnector = declarativeRestConnector({
parameters: {
type: 'object',
properties: {
$search: { type: 'string' },
$filter: { type: 'string' },
$select: { type: 'string' },
$top: { type: 'integer' },
$orderby: { type: 'string' },
search: { type: 'string' },
filter: { type: 'string' },
select: { type: 'string' },
top: { type: 'integer' },
orderBy: { type: 'string' },
contactFolderId: { type: 'string' },
},
},
request: {
method: 'GET',
path: '/me/contactFolders/{contactFolderId}/contacts',
query: {
$search: '{$search}',
$filter: '{$filter}',
$select: '{$select}',
$top: '{$top}',
$orderby: '{$orderby}',
$search: '{search}',
$filter: '{filter}',
$select: '{select}',
$top: '{top}',
$orderby: '{orderBy}',
},
},
requiredScopes: ['Contacts.ReadWrite'],
Expand Down
48 changes: 24 additions & 24 deletions src/connectors/adapters/microsoft-calendar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,12 @@ export function microsoftCalendar(opts: MicrosoftCalendarOptions): ConnectorAdap
type: 'object',
properties: {
calendarId: { type: 'string', description: "Calendar id; defaults to the user's primary calendar when omitted." },
$top: { type: 'integer', description: 'Max events to return (OData page size).' },
$skip: { type: 'integer', description: 'Number of events to skip (OData paging offset).' },
$filter: { type: 'string', description: 'OData $filter expression.' },
$select: { type: 'string', description: 'Comma-separated event fields to project.' },
$orderby: { type: 'string', description: 'OData $orderby expression.' },
$search: { type: 'string', description: 'OData $search query.' },
top: { type: 'integer', description: 'Max events to return (OData page size).' },
skip: { type: 'integer', description: 'Number of events to skip (OData paging offset).' },
filter: { type: 'string', description: 'OData $filter expression.' },
select: { type: 'string', description: 'Comma-separated event fields to project.' },
orderBy: { type: 'string', description: 'OData $orderby expression.' },
search: { type: 'string', description: 'OData $search query.' },
},
},
},
Expand All @@ -191,20 +191,20 @@ export function microsoftCalendar(opts: MicrosoftCalendarOptions): ConnectorAdap
if (inv.capabilityName === 'list_events') {
const {
calendarId,
$top,
$skip,
$filter,
$select,
$orderby,
$search,
top,
skip,
filter,
select,
orderBy,
search,
} = inv.args as {
calendarId?: string
$top?: number
$skip?: number
$filter?: string
$select?: string
$orderby?: string
$search?: string
top?: number
skip?: number
filter?: string
select?: string
orderBy?: string
search?: string
}
// /me/calendars/{calendarId}/events when a calendar is pinned, else the
// primary-calendar shorthand /me/events. Mirrors the duplicate's
Expand All @@ -213,12 +213,12 @@ export function microsoftCalendar(opts: MicrosoftCalendarOptions): ConnectorAdap
? `https://graph.microsoft.com/v1.0/me/calendars/${encodeURIComponent(calendarId)}/events`
: 'https://graph.microsoft.com/v1.0/me/events'
const qs = new URLSearchParams()
if ($top !== undefined) qs.set('$top', String($top))
if ($skip !== undefined) qs.set('$skip', String($skip))
if ($filter) qs.set('$filter', $filter)
if ($select) qs.set('$select', $select)
if ($orderby) qs.set('$orderby', $orderby)
if ($search) qs.set('$search', $search)
if (top !== undefined) qs.set('$top', String(top))
if (skip !== undefined) qs.set('$skip', String(skip))
if (filter) qs.set('$filter', filter)
if (select) qs.set('$select', select)
if (orderBy) qs.set('$orderby', orderBy)
if (search) qs.set('$search', search)
const query = qs.toString()
const url = query ? `${base}?${query}` : base
const res = await fetch(url, {
Expand Down
6 changes: 3 additions & 3 deletions src/connectors/adapters/microsoft-dynamics-crm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,15 @@ export const microsoftDynamicsCrmConnector = declarativeRestConnector({
properties: {
entitySet: { type: 'string' },
recordId: { type: 'string' },
$select: { type: 'string' },
$expand: { type: 'string' },
select: { type: 'string' },
expand: { type: 'string' },
},
required: ['entitySet', 'recordId'],
},
request: {
method: 'GET',
path: '/api/data/v9.2/{entitySet}({recordId})',
query: { $select: '{$select}', $expand: '{$expand}' },
query: { $select: '{select}', $expand: '{expand}' },
},
},
{
Expand Down
18 changes: 9 additions & 9 deletions src/connectors/adapters/microsoft-excel-365.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,16 @@ export const microsoftExcel365Connector = declarativeRestConnector({
parameters: {
type: 'object',
properties: {
$search: { type: 'string' },
$filter: { type: 'string' },
$top: { type: 'integer' },
$select: { type: 'string' },
search: { type: 'string' },
filter: { type: 'string' },
top: { type: 'integer' },
select: { type: 'string' },
},
},
request: {
method: 'GET',
path: '/me/drive/root/search(q={$search})',
query: { $filter: '{$filter}', $top: '{$top}', $select: '{$select}' },
path: '/me/drive/root/search(q={search})',
query: { $filter: '{filter}', $top: '{top}', $select: '{select}' },
},
requiredScopes: ['Files.ReadWrite'],
},
Expand Down Expand Up @@ -232,15 +232,15 @@ export const microsoftExcel365Connector = declarativeRestConnector({
properties: {
workbookId: { type: 'string' },
tableId: { type: 'string' },
$top: { type: 'integer' },
$skip: { type: 'integer' },
top: { type: 'integer' },
skip: { type: 'integer' },
},
required: ['workbookId', 'tableId'],
},
request: {
method: 'GET',
path: '/me/drive/items/{workbookId}/workbook/tables/{tableId}/rows',
query: { $top: '{$top}', $skip: '{$skip}' },
query: { $top: '{top}', $skip: '{skip}' },
},
requiredScopes: ['Files.ReadWrite'],
},
Expand Down
22 changes: 11 additions & 11 deletions src/connectors/adapters/microsoft-onenote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,15 @@ export const microsoftOnenoteConnector = declarativeRestConnector({
parameters: {
type: 'object',
properties: {
$top: { type: 'integer' },
$filter: { type: 'string' },
$select: { type: 'string' },
top: { type: 'integer' },
filter: { type: 'string' },
select: { type: 'string' },
},
},
request: {
method: 'GET',
path: '/me/onenote/notebooks',
query: { $top: '{$top}', $filter: '{$filter}', $select: '{$select}' },
query: { $top: '{top}', $filter: '{filter}', $select: '{select}' },
},
},
{
Expand All @@ -82,15 +82,15 @@ export const microsoftOnenoteConnector = declarativeRestConnector({
type: 'object',
properties: {
notebookId: { type: 'string' },
$top: { type: 'integer' },
$filter: { type: 'string' },
top: { type: 'integer' },
filter: { type: 'string' },
},
required: ['notebookId'],
},
request: {
method: 'GET',
path: '/me/onenote/notebooks/{notebookId}/sections',
query: { $top: '{$top}', $filter: '{$filter}' },
query: { $top: '{top}', $filter: '{filter}' },
},
},
{
Expand All @@ -102,16 +102,16 @@ export const microsoftOnenoteConnector = declarativeRestConnector({
type: 'object',
properties: {
sectionId: { type: 'string' },
$top: { type: 'integer' },
$filter: { type: 'string' },
$search: { type: 'string' },
top: { type: 'integer' },
filter: { type: 'string' },
search: { type: 'string' },
},
required: ['sectionId'],
},
request: {
method: 'GET',
path: '/me/onenote/sections/{sectionId}/pages',
query: { $top: '{$top}', $filter: '{$filter}', $search: '{$search}' },
query: { $top: '{top}', $filter: '{filter}', $search: '{search}' },
},
},
{
Expand Down
Loading
Loading